Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate code for the ES6 target #2565

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Generate code for the ES6 target #2565

merged 4 commits into from
Jul 29, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 28, 2022

Close #2564

mergify[bot]
mergify bot approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@tomaka tomaka mentioned this pull request Jul 28, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2022 •
edited
Loading

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jul 29, 2022
@mergify mergify bot merged commit 6971658 into paritytech:main Jul 29, 2022
@tomaka tomaka deleted the es6 branch July 29, 2022 08:51
@petersopko
Copy link

thanks for the fix guys, when can we expect the release on this? We've added checks for win machines and this seems to be universal problem in win builds kodadot/nft-gallery#3603

This was referenced Jul 29, 2022
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path to smoldot on win
3 participants
@tomaka @petersopko @melekes