-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cross env and test windows build #3603
Add cross env and test windows build #3603
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cc @petersopko |
I'm not sure I understand what should i test; it seems to me as a code only. |
don't worry about this one, it's code only :) |
let's wait for paritytech/smoldot#2565 to test this out and see it working :) |
seems already released. because the package is too deep, need parent dependencies to update also. we can speed it up to test by forcing the package version with "overrides": {
"@substrate/smoldot-light": "^0.6.27"
}
|
hmm, just adding this "overrides" thing doesn't help, I've added it to package.json, hit |
hmm, just add this line, like in this PR. with that changes in this PR, the build was a success in windows |
this actually worked! wonderful 🚀 let's wait for @prachi00 to check the code and we're good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wfm
LGTM |
@preschian I'm wondering whether we have to have the over ride here now, since the packages and dependencies were updated? polkadot-js/api@8308715 |
still not yet I think, latest version was released 4 days ago, and the PR just merged yesterday oh, one thing. need to update the GitHub branch protection rule, because in this PR I added build for windows, and steps names were automatically renamed to |
pay 100 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot