Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross env and test windows build #3603

Merged
merged 15 commits into from
Aug 4, 2022

Conversation

preschian
Copy link
Member

@preschian preschian commented Jul 29, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged the recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit e84611f
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62eba35ffbbd450008839c27
😎 Deploy Preview https://deploy-preview-3603--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review July 29, 2022 08:18
@preschian preschian requested review from a team as code owners July 29, 2022 08:18
@preschian preschian requested review from prachi00 and DeluneClaire and removed request for a team July 29, 2022 08:18
@preschian
Copy link
Member Author

cc @petersopko

@DeluneClaire
Copy link

I'm not sure I understand what should i test; it seems to me as a code only.

@petersopko
Copy link
Contributor

I'm not sure I understand what should i test; it seems to me as a code only.

don't worry about this one, it's code only :)

@petersopko petersopko requested review from petersopko and removed request for DeluneClaire July 29, 2022 11:19
@petersopko
Copy link
Contributor

cc @petersopko

let's wait for paritytech/smoldot#2565 to test this out and see it working :)

@preschian
Copy link
Member Author

let's wait for paritytech/smoldot#2565 to test this out and see it working :)

seems already released. because the package is too deep, need parent dependencies to update also. we can speed it up to test by forcing the package version with overrides to force the package version.

"overrides": {
  "@substrate/smoldot-light": "^0.6.27"
}
before after
Screen Shot 2022-07-30 at 15 54 24 Screen Shot 2022-07-30 at 15 54 58

@petersopko
Copy link
Contributor

let's wait for paritytech/smoldot#2565 to test this out and see it working :)

seems already released. because the package is too deep, need parent dependencies to update also. we can speed it up to test by forcing the package version with overrides to force the package version.

"overrides": {
  "@substrate/smoldot-light": "^0.6.27"
}

hmm, just adding this "overrides" thing doesn't help, I've added it to package.json, hit pnpm i and then tried build again, it still gets stuck at 0.6.25. Any idea how to achieve what you've got there on the right side @preschian ?

@preschian
Copy link
Member Author

hmm, just adding this "overrides" thing doesn't help, I've added it to package.json, hit pnpm i and then tried build again, it still gets stuck at 0.6.25. Any idea how to achieve what you've got there on the right side @preschian ?

hmm, just add this line, like in this PR. with that changes in this PR, the build was a success in windows
refer to this file, bottom line section https://github.com/kodadot/nft-gallery/blob/1dd8ba7817adc4dc24aeb6320b17d48b61128c6f/package.json
Screen Shot 2022-08-01 at 09 16 33

@petersopko
Copy link
Contributor

hmm, just adding this "overrides" thing doesn't help, I've added it to package.json, hit pnpm i and then tried build again, it still gets stuck at 0.6.25. Any idea how to achieve what you've got there on the right side @preschian ?

hmm, just add this line, like in this PR. with that changes in this PR, the build was a success in windows refer to this file, bottom line section https://github.com/kodadot/nft-gallery/blob/1dd8ba7817adc4dc24aeb6320b17d48b61128c6f/package.json Screen Shot 2022-08-01 at 09 16 33

this actually worked! wonderful 🚀

let's wait for @prachi00 to check the code and we're good to go

Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@petersopko petersopko added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 2, 2022
@prachi00
Copy link
Member

prachi00 commented Aug 2, 2022

LGTM

@petersopko
Copy link
Contributor

@preschian I'm wondering whether we have to have the over ride here now, since the packages and dependencies were updated? polkadot-js/api@8308715

@preschian
Copy link
Member Author

@preschian I'm wondering whether we have to have the over ride here now, since the packages and dependencies were updated? polkadot-js/api@8308715

still not yet I think, latest version was released 4 days ago, and the PR just merged yesterday
Screen Shot 2022-08-03 at 15 17 09

oh, one thing. need to update the GitHub branch protection rule, because in this PR I added build for windows, and steps names were automatically renamed to build (ubuntu-latest) and build (windows-latest) from build

something like this:
cc @yangwao @vikiival
Screen Shot 2022-08-03 at 15 20 45

@vikiival
Copy link
Member

vikiival commented Aug 4, 2022

Screenshot 2022-08-04 at 13 14 45

@petersopko petersopko merged commit 3df5653 into kodadot:main Aug 4, 2022
@petersopko
Copy link
Contributor

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Aug 4, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 60.85 USD/KSM ~ 1.643 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x049fccc01e29739105279a34a909add93fb6b70af0b08c5a336aaf7a03e13f19

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants