Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report reason for shutdown in collection.rs #2429

Merged
merged 5 commits into from
Jun 27, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jun 24, 2022

When a connection starts its shutdown phase, we now report why.
This is at the moment only reported by the API of collection.rs, and we need #2370 in order to propagate it further.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼────────────────────────────────────────────────────────────────────────────────────────────
       +3638 ┊ smoldot::libp2p::collection::Network<TConn,TNow>::next_event::hf765bac886403693
       -3602 ┊ smoldot::libp2p::collection::Network<TConn,TNow>::next_event::h68df47466f700250
        -241 ┊ <smoldot::libp2p::collection::RequestError as core::clone::Clone>::clone::h30c3e32cddae463b
        +241 ┊ <smoldot::libp2p::collection::RequestError as core::clone::Clone>::clone::h61c24b04b739da7e
        -225 ┊ alloc::collections::vec_deque::ring_slices::RingSlices::ring_slices::h014e653fe69bc4c2
        +225 ┊ alloc::collections::vec_deque::ring_slices::RingSlices::ring_slices::h1cad2d3fbfc36a72
        +225 ┊ alloc::collections::vec_deque::ring_slices::RingSlices::ring_slices::ha366ee058002abc1
        -225 ┊ alloc::collections::vec_deque::ring_slices::RingSlices::ring_slices::hedb564612c10e597
        +202 ┊ alloc::raw_vec::RawVec<T,A>::grow_exact::h2ae08296266d2735
        -202 ┊ alloc::raw_vec::RawVec<T,A>::grow_exact::h64736d42396aed2d
        +202 ┊ alloc::raw_vec::RawVec<T,A>::grow_exact::ha4fa756fa17baece
        -202 ┊ alloc::raw_vec::RawVec<T,A>::grow_exact::hc43c9bca3fb1bacc
        +190 ┊ alloc::collections::vec_deque::VecDeque<T,A>::grow::h9f24b5f191d38eb3
        -190 ┊ alloc::collections::vec_deque::VecDeque<T,A>::grow::ha443f8a99941045c
        -190 ┊ alloc::collections::vec_deque::VecDeque<T,A>::grow::hbbe5cce25f2c0364
        +190 ┊ alloc::collections::vec_deque::VecDeque<T,A>::grow::hfec808c1cb12358c
        -181 ┊ alloc::raw_vec::RawVec<T,A>::allocate_in::h105339d8a9c80936
        -181 ┊ alloc::raw_vec::RawVec<T,A>::allocate_in::h1237c7d322b926e6
        +181 ┊ alloc::raw_vec::RawVec<T,A>::allocate_in::hb90dee381cad2372
        +181 ┊ alloc::raw_vec::RawVec<T,A>::allocate_in::hbcdc89653607308f
        +173 ┊ ... and 65 more.
        +209 ┊ Σ [85 Total Rows]

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jun 27, 2022
@mergify mergify bot merged commit 5e9dd4a into paritytech:main Jun 27, 2022
@tomaka tomaka deleted the shutdown-reason branch June 27, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants