Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding a "shutting down" phase in the API of peers.rs #2370

Closed
tomaka opened this issue Jun 10, 2022 · 0 comments · Fixed by #2610
Closed

Consider adding a "shutting down" phase in the API of peers.rs #2370

tomaka opened this issue Jun 10, 2022 · 0 comments · Fixed by #2610

Comments

@tomaka
Copy link
Contributor

tomaka commented Jun 10, 2022

See #2369 for an explanation.

Instead of having a fake requests system, we should consider notifying the upper API layers that we only have one connection and that it is shutting down.

This might cause other consistency issues, so I don't know whether it's a good idea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaws in the API of peers.rs tomaka/substrate-lite-1
1 participant
@tomaka