Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove source knows block after verification #2168

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Don't remove source knows block after verification #2168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c30a9b4
Don't remove source knows block after verification
tomaka Mar 22, 2022
1e0ea3c
Changelog
tomaka Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bin/wasm-node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixed

- Fix regression introduced in version 0.6.5 where we erroneously removed entries in the mapping of which peer knows which blocks, leading to failures to request data. ([#2168](https://github.com/paritytech/smoldot/pull/2168))

## 0.6.7 - 2022-03-22

### Changed
Expand Down
4 changes: 0 additions & 4 deletions src/sync/all_forks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,10 +1584,6 @@ impl<TBl, TRq, TSrc> HeaderVerify<TBl, TRq, TSrc> {
// Block is valid!

// Remove the block from `pending_blocks`.
self.parent.inner.blocks.remove_sources_known_block(
self.block_to_verify.block_number,
&self.block_to_verify.block_hash,
);
let pending_block = self.parent.inner.blocks.remove_unverified_block(
self.block_to_verify.block_number,
&self.block_to_verify.block_hash,
Expand Down