Don't remove source knows block after verification #2168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #2114
I don't know why I had added this call to
remove_sources_known_block
after a block has been successfully verified. Not only it is obviously wrong, but in #2114 I tried to not change the behavior and added this call that explicitly changes the behavior.Unfortunately the lack of testing didn't help, but the problem got caught by https://github.com/paritytech/substrate-connect/runs/5590927994?check_suite_focus=true