Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove source knows block after verification #2168

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 22, 2022

Fixes a bug introduced in #2114

I don't know why I had added this call to remove_sources_known_block after a block has been successfully verified. Not only it is obviously wrong, but in #2114 I tried to not change the behavior and added this call that explicitly changes the behavior.

Unfortunately the lack of testing didn't help, but the problem got caught by https://github.com/paritytech/substrate-connect/runs/5590927994?check_suite_focus=true

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────
         -16 ┊ smoldot::sync::all_forks::HeaderVerify<TBl,TRq,TSrc>::perform::h52cc25e098199667
         -16 ┊ Σ [1 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Mar 23, 2022
@mergify mergify bot merged commit 970ad39 into paritytech:main Mar 23, 2022
@tomaka tomaka deleted the fix-fuckup branch March 23, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants