Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix the browser light client #892

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Fix the browser light client #892

merged 2 commits into from
Mar 10, 2020

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Mar 9, 2020

A recent tokio update seems to not compile on wasm32-unknown-unknown. The easiest work around for this is to just not pull in things like polkadot-validation that we don't use in the light client anyway.

@expenses expenses requested review from tomaka and bkchr March 9, 2020 15:21
@rphmeier
Copy link
Contributor

rphmeier commented Mar 9, 2020

Seems a bit hacky. Could we rather do that with a feature flag that will be disabled for browser light-client compilations?

@expenses
Copy link
Contributor Author

expenses commented Mar 9, 2020

Yeah, I could change the blocks from #[cfg(not(target_os = "unknown"))] to #[cfg(feature = "full-node"))] but I'm not sure if that's a huge improvement.

@tomaka
Copy link
Contributor

tomaka commented Mar 10, 2020

It would be an improvement. I say this at almost all your PRs: there's no fundamental reason why we can't compile a full node on WASM, and we should therefore limit our platform-specific code to the very strict minimum.

@expenses expenses merged commit 83f10b3 into master Mar 10, 2020
@expenses expenses deleted the ashley-fix-browser-node branch March 10, 2020 13:29
General-Beck pushed a commit to General-Beck/polkadot that referenced this pull request Mar 19, 2020
* Fix browser node

* Use feature instead
HCastano added a commit to HCastano/polkadot that referenced this pull request Apr 15, 2021
5330d84e CLI: naming clean-up. (paritytech#897)
f99f2225 Westend<>Rococo Headers Relay (paritytech#875)
72c9117b Use complex headers+messages relay in test deployments (paritytech#905)
48423d5b Stop recursing when creating test headers (paritytech#906)
f8586fd4 Fix outstanding bridge names. (paritytech#901)
54b683b3 Complex headers+messages Millau<->Rialto relay (paritytech#878)
c0e77ca1 fix message generator scripts (paritytech#900)
debf3a82 Use Substrate state_getReadProof RPC method to get storage proofs (paritytech#893)
c3fa7216 Support more than `u8::max_value` GRANDPA validators (paritytech#896)
e5cb87f9 Grandpa Pallet Pruning (paritytech#890)
0b6a8920 RestartNeeded is a connection error (paritytech#894)
2cf5fa26 CLI: Estimate Fee (paritytech#888)
7dace624 CLI: Send Message (paritytech#886)
f8eaecfa CLI: Encode Message (paritytech#889)
1610f868 Bump `jsonrpsee` to Alpha.3 (paritytech#892)
d665b531 Use new Cargo feature resolver (paritytech#891)
ce2ee6ed Rialto Millau Maintenance Dashboard (paritytech#881)
7c585ce8 Revert to older nightly. (paritytech#887)
73a0470e Adding GrandpaJustification custom type (paritytech#882)
b9ccea9c Install CA certificates in relay images (paritytech#880)
ec7841a2 fix widget names (paritytech#879)
REVERT: 746a4027 Accidentally committed `cargo-expand`ed code 🤦
REVERT: 1a5d09c5 Add note to more closely match `initialize` Call variant
REVERT: fdd6e6b3 Add `submit_finality_proof` mock Call variant
REVERT: 768b053e Simplify the Rococo and Westend signing params
REVERT: 62aca80e Add Westend<>Rococo variants to `relay_headers`
REVERT: 0bcb0f51 Add Westend<>Rococo variants to `init_bridge`
REVERT: 01d1305f Use mock Westend and Rococo finaltiy tx calls
REVERT: fb34b9dd Add modules for Rococo<>Westend header sync

git-subtree-dir: bridges
git-subtree-split: 5330d84e9511e38cf9d9ec765bee865fedd4b260
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants