Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Kusama chainspecs #888

Closed
wants to merge 5 commits into from
Closed

Kusama chainspecs #888

wants to merge 5 commits into from

Conversation

arkpar
Copy link
Member

@arkpar arkpar commented Mar 8, 2020

Introduces development, local testing and staging chain specs for kusama.

Requires paritytech/substrate#5185

@arkpar arkpar added the A3-in_progress Pull request is in progress. No review needed at this stage. label Mar 8, 2020
bkchr
bkchr reviewed Mar 8, 2020
View reviewed changes
cli/src/cli.rs Show resolved Hide resolved
@arkpar arkpar changed the title A force kusama Kusama chainspecs Mar 8, 2020
bkchr
bkchr reviewed Mar 8, 2020
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can we not have an enum as ChainSpec?

enum ChainSpec {
    Polkadot(GenericChainSpec<polkadot::GenesisConfig, Extensions>),
    Kusama(GenericChainSpec<kusama::GenesisConfig, Extensions>),
}

cli/src/cli.rs Show resolved Hide resolved
service/src/chain_spec.rs Outdated Show resolved Hide resolved
@arkpar
Copy link
Member Author

arkpar commented Mar 9, 2020

Why can we not have an enum as ChainSpec?

And implement ChainSpec for that? But what for? That's too much extra code to achieve very little.

@bkchr
Copy link
Member

bkchr commented Mar 9, 2020

Yeah probably don't bring that much.

@arkpar arkpar added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 13, 2020
@arkpar arkpar marked this pull request as ready for review March 13, 2020 11:00
@gavofyork gavofyork closed this Mar 13, 2020
@arkpar arkpar deleted the a-force-kusama branch March 13, 2020 13:48
HCastano added a commit to HCastano/polkadot that referenced this pull request Apr 15, 2021
@HCastano
Squashed 'bridges/' changes from 746a4027..5330d84e
5abf22b 
5330d84e CLI: naming clean-up. (paritytech#897)
f99f2225 Westend<>Rococo Headers Relay (paritytech#875)
72c9117b Use complex headers+messages relay in test deployments (paritytech#905)
48423d5b Stop recursing when creating test headers (paritytech#906)
f8586fd4 Fix outstanding bridge names. (paritytech#901)
54b683b3 Complex headers+messages Millau<->Rialto relay (paritytech#878)
c0e77ca1 fix message generator scripts (paritytech#900)
debf3a82 Use Substrate state_getReadProof RPC method to get storage proofs (paritytech#893)
c3fa7216 Support more than `u8::max_value` GRANDPA validators (paritytech#896)
e5cb87f9 Grandpa Pallet Pruning (paritytech#890)
0b6a8920 RestartNeeded is a connection error (paritytech#894)
2cf5fa26 CLI: Estimate Fee (paritytech#888)
7dace624 CLI: Send Message (paritytech#886)
f8eaecfa CLI: Encode Message (paritytech#889)
1610f868 Bump `jsonrpsee` to Alpha.3 (paritytech#892)
d665b531 Use new Cargo feature resolver (paritytech#891)
ce2ee6ed Rialto Millau Maintenance Dashboard (paritytech#881)
7c585ce8 Revert to older nightly. (paritytech#887)
73a0470e Adding GrandpaJustification custom type (paritytech#882)
b9ccea9c Install CA certificates in relay images (paritytech#880)
ec7841a2 fix widget names (paritytech#879)
REVERT: 746a4027 Accidentally committed `cargo-expand`ed code 🤦
REVERT: 1a5d09c5 Add note to more closely match `initialize` Call variant
REVERT: fdd6e6b3 Add `submit_finality_proof` mock Call variant
REVERT: 768b053e Simplify the Rococo and Westend signing params
REVERT: 62aca80e Add Westend<>Rococo variants to `relay_headers`
REVERT: 0bcb0f51 Add Westend<>Rococo variants to `init_bridge`
REVERT: 01d1305f Use mock Westend and Rococo finaltiy tx calls
REVERT: fb34b9dd Add modules for Rococo<>Westend header sync

git-subtree-dir: bridges
git-subtree-split: 5330d84e9511e38cf9d9ec765bee865fedd4b260
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkpar @bkchr @gavofyork