This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
*: Ensure GossipEngine is being polled #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With paritytech/substrate#4767 a `GossipEngine` does not spawn its own tasks, but relies on its owner to poll it. This patch removes the unneeded executor argument and spawns the gossip engine as an orphaned task onto the executor instead.
|
It looks like @mxinden signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
|
Friendly ping @rphmeier @andresilva. |
rphmeier
approved these changes
Feb 13, 2020
rphmeier
reviewed
Feb 13, 2020
| POLKADOT_ENGINE_ID, | ||
| gossip_side, | ||
| ); | ||
|
|
||
| // Ideally this would not be spawned as an orphaned task, but polled by | ||
| // `RegisteredMessageValidator` which in turn would be polled by a `ValidationNetwork`. |
There was a problem hiding this comment.
note that when we remove the legacy code we will use protocol.rs which could run this in a future.
andresilva
approved these changes
Feb 13, 2020
| // `RegisteredMessageValidator` which in turn would be polled by a `ValidationNetwork`. | ||
| let spawn_res = executor.spawn_obj(futures::task::FutureObj::from(Box::new(gossip_engine.clone()))); | ||
|
|
||
| // Note: we consider the chances of an error to spawn a background task almost null. |
There was a problem hiding this comment.
I agree, but should we panic instead? This code will only be run on node startup, maybe it makes sense to just fail right away?
There was a problem hiding this comment.
A graceful exit would be hard to include, but maybe a warning would be good.
rphmeier
added
A1-onice
and removed
A0-please_review
|
Superseded by: #834 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With paritytech/substrate#4767 a
GossipEnginedoes not spawn its own tasks, but relies on its owner to poll it. This
patch removes the unneeded executor argument and spawns the gossip
engine as an orphaned task onto the executor instead.
ba3b548 is the core of the pull request and should be reviewed.
c1fb81b is temporary and makes Polkadot use a patched version of Substrate's polkadot-master which includes paritytech/substrate#4767.
🛑 Please don't merge yet, given that c1fb81b is not yet removed.