Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Updates needed for substrate #4820 (composite accounts) #834

Closed
wants to merge 50 commits into from
Closed

Updates needed for substrate #4820 (composite accounts) #834

wants to merge 50 commits into from

Conversation

gavofyork
Copy link
Member

No description provided.

gavofyork and others added 30 commits January 20, 2020 19:53
@gavofyork
Amalgamate pieces of balance module
2383ba9
@gavofyork
Merge branch 'master' of github.com:paritytech/polkadot
62023ac
@gavofyork
Fixes for vesting split
e4065cb
@gavofyork
Refactoring for vesting/balances split
f7d05c8
@gavofyork
Build fixes
372908d
@gavofyork
Remove on_free_balance_zero and some docs.
f9b2b2f
@gavofyork
Indentation.
c51f4d7
@gavofyork
Merge branch 'gav-split-balanecs-vesting' into gav-upsub
84ed49c
@gavofyork
Revert branch
94b9d10
@gavofyork
Fix.
d7b44ec
@cecton
Update substrate: fixes after CLI refactoring
4013a30
@rphmeier
Merge branch 'master' into gav-upsub
830f819
@cecton
Reverting removal of exit
b5f436a
@cecton
Removed too much again
1df7547
@cecton
Update Cargo.lock
7916135
@cecton
Cargo.lock
96a0c87
@gavofyork
Update Substrate, ready for #4820
a1f25b4
@gavofyork
Merge branch 'gav-upsub' of github.com:paritytech/polkadot into gav-u…
bebc910 
…psub
@gavofyork
Fixes
6b05cb4
@bkchr
Merge remote-tracking branch 'origin/cecton-cli-refactoring-more' int…
bffee5e 
…o gav-upsub
@gavofyork
Merge remote-tracking branch 'origin/cecton-cli-refactoring-more' int…
3441e24 
…o gav-upsub
@gavofyork
Merge branch 'gav-upsub' of github.com:paritytech/polkadot into gav-u…
142b9c9 
…psub
@bkchr
Update to latest substrate master
09e6236
@bkchr
Fix network tests
691c6c3
@gavofyork
Changes needed for substrate/#4820
e710b5b
@gavofyork
Remove StaticLookup
7f7ce20
@gavofyork
Bump version to 0.7.21
c563e9d
@apopiak
rename uses of StorageMap::exists(key) to ::contains_key(key)
ab23e94
@apopiak
use substrate PR branch
587a1fd
@apopiak
adjust impl_version according to substrate change
e124686
@jacogr
Copy link
Contributor

jacogr commented Feb 10, 2020 •
edited
Loading

Tested this against an API with the type Address = AccountId and transfers as well as remarks works as expected. Checked the transactions -

  • "from" address passed as an AccountId (32-bytes )works as expected (in unchecked)
  • using AccountId as lookup source (e.g. transfer "to") works as expected
  • data shows up under system.account (balances)

So functionally it looks correct from my early testing. Will run through more.

Edit/Update:

  • as expected, on new accounts a new index is not created (and no event)
  • merged support for running polkadot --dev in the JS API 1 2-beta.5 as well as current deployed apps UI (this also applies to Kusama 1046+, this can be adjusted if it only goes much later)

Overall, lgtm, does what it says on the tin.

@jacogr jacogr mentioned this pull request Feb 10, 2020
Merged
@bkchr bkchr mentioned this pull request Feb 15, 2020
Closed
@mxinden @bkchr
*: Ensure GossipEngine is being polled
335d0de 
With paritytech/substrate#4767 a `GossipEngine`
does not spawn its own tasks, but relies on its owner to poll it. This
patch removes the unneeded executor argument and spawns the gossip
engine as an orphaned task onto the executor instead.
@bkchr bkchr mentioned this pull request Feb 15, 2020
Closed
@gavofyork gavofyork mentioned this pull request Feb 18, 2020
Closed
24 tasks
shawntabrizi
shawntabrizi reviewed Feb 19, 2020
View reviewed changes
runtime/common/src/claims.rs

// If this fails, destination account already has a vesting schedule
// applied to it, and this claim should not be processed.
ensure!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you removed this ensure check, I also believe you now made it possible for someone with a vesting schedule to drop the pot to zero by calling this function over and over.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the logic and added a test which would have failed if this logic didn't exist.

15fe7cc

shawntabrizi
shawntabrizi approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would be good to get second review of the fix I pushed into the claims

jacogr
jacogr approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been testing it all the way through, so functionality-wise lgtm.

@NikVolf
Copy link
Contributor

NikVolf commented Feb 19, 2020 •
edited
Loading

I've included changes in #853

@NikVolf NikVolf mentioned this pull request Feb 19, 2020
Merged
@andresilva
Copy link
Contributor

Superseded by #853.

@andresilva andresilva closed this Feb 19, 2020
@shawntabrizi shawntabrizi deleted the gav-composite-account branch February 19, 2020 17:28
tomusdrw pushed a commit that referenced this pull request Mar 26, 2021
@svyatonik
Rename pallet-message-lane into pallet-bridge-messages (#834)
5eb919e 
* use runtime:: prefix for message-lane pallet traces

* renamed message-lane (module and primitives) folder into messages

* replace "message lane" with "messages" where appropriate
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.