[pallet-revive] implement the base fee API #6964
Conversation
Signed-off-by: xermicus <[email protected]>
xermicus
added
R0-silent
|
bot fmt |
|
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7940391 was started for your command Comment |
|
@xermicus Command |
|
/cmd prdoc --audience runtime_dev --bump minor |
|
/cmd bench --runtime dev --pallet pallet_revive |
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
Why? Isn't this a balance value which could theoretically exceed u64? |
Ah yes of course - I just short-circuited it because the gas price is currently |
Signed-off-by: xermicus <[email protected]>
Signed-off-by: xermicus <[email protected]>
|
/cmd bench --runtime dev --pallet pallet_revive |
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
Strictly speaking it is capped to u128 which is our balance type everywhere. But it is a generic type. And in these cases we exposed it as u256 in all other places. |
|
@athei yes I fully agree. |
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Not demanding to remove this in principle SPDX already fixes this up, and rest is redundant information.
There was a problem hiding this comment.
If we want to change the header it needs to be a separate PR changing headers in all files.
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
If we want to change the header it needs to be a separate PR changing headers in all files.
Signed-off-by: Cyrill Leutwiler <[email protected]>
This PR implements the base fee syscall API method. Currently this is implemented as a compile time constant in the revive compiler, returning 0. However, since this is an opocde, if we ever need to implement it for compatibility reasons with EIP-1559, it would break already deployed contracts. Thus we provide a syscall method instead.