Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support weight related opcodes #60

Closed
4 tasks done
xermicus opened this issue Oct 4, 2024 · 1 comment
Closed
4 tasks done

Support weight related opcodes #60

xermicus opened this issue Oct 4, 2024 · 1 comment
Assignees

Comments

@xermicus
Copy link
Member

xermicus commented Oct 4, 2024

The opcodes basefee, gasprice and gaslimits needs some research first: In Substrate we have 2D weights; also our ref time dimension does not translate 1:1 to EVM gas. Note: Frontier and ETH L2 implementation already thought about this.

Once we figured a consistent solution, contract calls should no longer ignore the supplied gas limit.

@xermicus xermicus added this to the Initial release milestone Oct 25, 2024
@athei athei moved this to Minimal Feature Launch in Smart Contracts Dec 11, 2024
@athei athei moved this from Minimal Feature Launch to Polkadot APIs in Smart Contracts Dec 11, 2024
@athei athei moved this from Polkadot APIs to Minimal Feature Launch in Smart Contracts Dec 11, 2024
@athei athei moved this from Minimal Feature Launch to Polkadot APIs in Smart Contracts Dec 11, 2024
@athei athei moved this from Polkadot APIs to Minimal Feature Launch in Smart Contracts Dec 11, 2024
@athei
Copy link
Member

athei commented Dec 12, 2024

Also the GASopcode needs to be changed to call into the pallet (currently it uses a hard coded value). Change the weight_left syscall to reftime_left for that. It should just return ref time in the output register.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Minimal Feature Launch
Development

No branches or pull requests

2 participants