cli/net_params: Warn on empty public-addr when starting a validator node #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
dmitry-markin
approved these changes
Aug 5, 2024
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
dmitry-markin
approved these changes
Aug 5, 2024
Signed-off-by: Alexandru Vasile <[email protected]>
skunert
reviewed
Aug 6, 2024
substrate/client/cli/src/config.rs
Outdated
| }) | ||
| }; | ||
|
|
||
| // TODO: Return error here in the next release. |
There was a problem hiding this comment.
We should have an issue for this and link the place where to add IMO. Already too many dead TODOs in the code 😬
skunert
approved these changes
Aug 6, 2024
Signed-off-by: Alexandru Vasile <[email protected]>
alexggh
reviewed
Aug 7, 2024
| @@ -638,6 +644,14 @@ pub trait CliConfiguration<DCV: DefaultConfigurationValues = ()>: Sized { | |||
|
|
|||
| logger.init()?; | |||
|
|
|||
| if config.role.is_authority() && config.network.public_addresses.is_empty() { | |||
There was a problem hiding this comment.
Did you check parachain collators(is_authorithy returns true) won't get this warning?
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Aug 28, 2024
…ode (paritytech#5240) This PR shows a warning when the `--public-addr` is not provided for validators. In the future, we'll transform this warning into a hard failure. Validators are encouraged to provide this parameter for better availability over the network. cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows a warning when the
--public-addris not provided for validators.In the future, we'll transform this warning into a hard failure. Validators are encouraged to provide this parameter for better availability over the network.
cc @paritytech/networking