Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid warning for parachain node #6280

Closed
xlc opened this issue Oct 30, 2024 · 4 comments · Fixed by #6298
Closed

Invalid warning for parachain node #6280

xlc opened this issue Oct 30, 2024 · 4 comments · Fixed by #6298
Assignees
@lexnv

Comments

@xlc
Copy link
Contributor

xlc commented Oct 30, 2024 •
edited
Loading 

WARNING: No public address specified, validator node may not be reachable.
          Consider setting `--public-addr` to the public IP address of this node.
          This will become a hard requirement in future versions.
WARNING: No public address specified, validator node may not be reachable.
          Consider setting `--public-addr` to the public IP address of this node.
          This will become a hard requirement in future versions.

got this warning with using omni parachain node from stable2409 branch, which is false positive. it is kind of a blocker before we would like to push this version out for all Acala node operators
and it got printed twice, implying the validator flag is also enabled for the relaychain part, which is wrong
@xlc xlc mentioned this issue Oct 30, 2024
Merged
@skunert
Copy link
Contributor

skunert commented Oct 30, 2024

cc @lexnv

@lexnv lexnv self-assigned this Oct 30, 2024
@kianenigma
Copy link
Contributor

@jsdw @lexnv how fast can it be addressed? If it is not a monumental amount of work, I would like to ask you to please prioritize it to be merged before the next stable release, such that we can have a "use-able" omni node in stable2024-12?

@lexnv
Copy link
Contributor

lexnv commented Oct 30, 2024

Will prioritize this right away, sorry for the inconvenience

@lexnv lexnv mentioned this issue Oct 30, 2024
Merged
1 task
@lexnv
Copy link
Contributor

lexnv commented Nov 1, 2024

This should be addressed by:

The warning is now moved to the authority-discovery mechanism. It is printed when one public address cannot be deduced:

  • the node was not started with --public-addr
  • the node is behind a NAT and therefore has no public listen addresses

Initial Zombienet tests confirm this will no longer be printed for collators / parachain nodes, will have to take a second look since I'm not entirely familiar with collators, thanks for raising this issue 🙏

github-merge-queue bot pushed a commit that referenced this issue Nov 5, 2024
@lexnv @dmitry-markin @bkchr
authority-discovery: Populate DHT records with public listen addresses (
762f824 
#6298)

This PR's main goal is to add public listen addresses to the DHT
authorities records. This change improves the discoverability of
validators that did not provide the `--public-addresses` flag.

This PR populates the authority DHT records with public listen addresses
if any.

The change effectively ensures that addresses are added to the DHT
record in following order:
 1. Public addresses provided by CLI `--public-addresses`
 2. Maximum of 4 public (global) listen addresses (if any)
3. Any external addresses discovered from the network (ie from
`/identify` protocol)


While at it, this PR adds the following constraints on the number of
addresses:
- Total number of addresses cached is bounded at 16 (increased from 10).
- A maximum number of 32 addresses are published to DHT records
(previously unbounded).
  - A maximum of 4 global listen addresses are utilized.
      
This PR also removes the following warning:
`WARNING: No public address specified, validator node may not be
reachable.`

### Next Steps
- [ ] deploy and monitor in versi network

Closes: #6280
Part of: #5266

cc @paritytech/networking

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Dmitry Markin <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
github-actions bot pushed a commit that referenced this issue Nov 5, 2024
@lexnv @github-actions
authority-discovery: Populate DHT records with public listen addresses (
2fe297d 
#6298)

This PR's main goal is to add public listen addresses to the DHT
authorities records. This change improves the discoverability of
validators that did not provide the `--public-addresses` flag.

This PR populates the authority DHT records with public listen addresses
if any.

The change effectively ensures that addresses are added to the DHT
record in following order:
 1. Public addresses provided by CLI `--public-addresses`
 2. Maximum of 4 public (global) listen addresses (if any)
3. Any external addresses discovered from the network (ie from
`/identify` protocol)

While at it, this PR adds the following constraints on the number of
addresses:
- Total number of addresses cached is bounded at 16 (increased from 10).
- A maximum number of 32 addresses are published to DHT records
(previously unbounded).
  - A maximum of 4 global listen addresses are utilized.

This PR also removes the following warning:
`WARNING: No public address specified, validator node may not be
reachable.`

### Next Steps
- [ ] deploy and monitor in versi network

Closes: #6280
Part of: #5266

cc @paritytech/networking

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Dmitry Markin <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit 762f824)
lexnv added a commit that referenced this issue Nov 15, 2024
@lexnv @dmitry-markin @bkchr
authority-discovery: Populate DHT records with public listen addresses (
a519c47 
#6298)

This PR's main goal is to add public listen addresses to the DHT
authorities records. This change improves the discoverability of
validators that did not provide the `--public-addresses` flag.

This PR populates the authority DHT records with public listen addresses
if any.

The change effectively ensures that addresses are added to the DHT
record in following order:
 1. Public addresses provided by CLI `--public-addresses`
 2. Maximum of 4 public (global) listen addresses (if any)
3. Any external addresses discovered from the network (ie from
`/identify` protocol)


While at it, this PR adds the following constraints on the number of
addresses:
- Total number of addresses cached is bounded at 16 (increased from 10).
- A maximum number of 32 addresses are published to DHT records
(previously unbounded).
  - A maximum of 4 global listen addresses are utilized.
      
This PR also removes the following warning:
`WARNING: No public address specified, validator node may not be
reachable.`

### Next Steps
- [ ] deploy and monitor in versi network

Closes: #6280
Part of: #5266

cc @paritytech/networking

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Dmitry Markin <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexnv lexnv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

authority-discovery: Populate DHT records with public listen addresses paritytech/polkadot-sdk
4 participants
@xlc @kianenigma @skunert @lexnv