Backport 4229 Into v1.7.0 #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
added
the
A3-backport
|
The CI pipeline was cancelled due to failure one of the required jobs. |
EgorPopelyaev
merged commit 06d0d22
into
release-crates-io-v1.7.0
23 of 89 checks passed
Comment on lines
+43
to
+44
| pub struct MigrationToV2<T>(sp_std::marker::PhantomData<T>); | ||
| impl<T: Config + pallet_balances::Config> OnRuntimeUpgrade for MigrationToV2<T> { |
There was a problem hiding this comment.
Why are we not doing VersionedMigration + UncheckedMigrationToV2 as in #4229 ?
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
added a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 26, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/paritytech-update-for-april-2024/7646/8 |
bkchr
pushed a commit
that referenced
this pull request
Jun 6, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
bkchr
pushed a commit
that referenced
this pull request
Jun 6, 2024
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have `UncheckedOnRuntimeUpgrade`, so I do it the "old way".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4229 into the v1.7.0 release in order to support dependent runtimes. This version of the SDK doesn't have
UncheckedOnRuntimeUpgrade, so I do it the "old way".