Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stuck Collator Funds #4229

Merged
merged 16 commits into from
Apr 23, 2024
Merged

Fix Stuck Collator Funds #4229

merged 16 commits into from
Apr 23, 2024

Conversation

joepetrowski
Copy link
Contributor

Fixes #4206

In #1340 one of the storage types was changed from Candidates to CandidateList. Since the actual key includes the hash of this value, all of the candidates stored here are (a) "missing" and (b) unable to unreserve their candidacy bond.

This migration kills the storage values and refunds the deposit held for each candidate.

@joepetrowski joepetrowski added I2-bug The node fails to follow expected behavior. T2-pallets This PR/Issue is related to a particular pallet. T14-system_parachains This PR/Issue is related to system parachains. labels Apr 21, 2024
@joepetrowski joepetrowski marked this pull request as ready for review April 22, 2024 18:23
@joepetrowski joepetrowski requested a review from liamaharon April 22, 2024 18:23
@joepetrowski joepetrowski added this pull request to the merge queue Apr 23, 2024
Merged via the queue into master with commit eda5e5c Apr 23, 2024
137 of 138 checks passed
@joepetrowski joepetrowski deleted the fix-collator-locked-funds branch April 23, 2024 13:17
@nud3l nud3l mentioned this pull request Apr 24, 2024
Open
EgorPopelyaev pushed a commit that referenced this pull request Apr 24, 2024
@joepetrowski @georgepisaltu
@ggwpez @EgorPopelyaev
Fix Stuck Collator Funds (#4229)
631de29 
Fixes #4206

In #1340 one of the storage types was changed from `Candidates` to
`CandidateList`. Since the actual key includes the hash of this value,
all of the candidates stored here are (a) "missing" and (b) unable to
unreserve their candidacy bond.

This migration kills the storage values and refunds the deposit held for
each candidate.

---------

Signed-off-by: georgepisaltu <[email protected]>
Co-authored-by: georgepisaltu <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: georgepisaltu <[email protected]>
EgorPopelyaev pushed a commit that referenced this pull request Apr 24, 2024
@joepetrowski @georgepisaltu
@ggwpez @EgorPopelyaev
Fix Stuck Collator Funds (#4229)
062ad63 
Fixes #4206

In #1340 one of the storage types was changed from `Candidates` to
`CandidateList`. Since the actual key includes the hash of this value,
all of the candidates stored here are (a) "missing" and (b) unable to
unreserve their candidacy bond.

This migration kills the storage values and refunds the deposit held for
each candidate.

---------

Signed-off-by: georgepisaltu <[email protected]>
Co-authored-by: georgepisaltu <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: georgepisaltu <[email protected]>
EgorPopelyaev pushed a commit that referenced this pull request Apr 24, 2024
@joepetrowski @georgepisaltu
@ggwpez @EgorPopelyaev
Fix Stuck Collator Funds (#4229)
3dc463e 
Fixes #4206

In #1340 one of the storage types was changed from `Candidates` to
`CandidateList`. Since the actual key includes the hash of this value,
all of the candidates stored here are (a) "missing" and (b) unable to
unreserve their candidacy bond.

This migration kills the storage values and refunds the deposit held for
each candidate.

---------

Signed-off-by: georgepisaltu <[email protected]>
Co-authored-by: georgepisaltu <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: georgepisaltu <[email protected]>
EgorPopelyaev pushed a commit that referenced this pull request Apr 24, 2024
@joepetrowski @georgepisaltu
@ggwpez @EgorPopelyaev
Fix Stuck Collator Funds (#4229)
467c24d 
Fixes #4206

In #1340 one of the storage types was changed from `Candidates` to
`CandidateList`. Since the actual key includes the hash of this value,
all of the candidates stored here are (a) "missing" and (b) unable to
unreserve their candidacy bond.

This migration kills the storage values and refunds the deposit held for
each candidate.

---------

Signed-off-by: georgepisaltu <[email protected]>
Co-authored-by: georgepisaltu <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: georgepisaltu <[email protected]>
This was referenced Apr 25, 2024
Closed
Merged
EgorPopelyaev pushed a commit that referenced this pull request Apr 25, 2024
@joepetrowski
Backport 4229 Into v1.7.0 (#4288)
06d0d22 
Backport of #4229 into the v1.7.0 release in order to support dependent
runtimes. This version of the SDK doesn't have
`UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev pushed a commit that referenced this pull request Apr 26, 2024
@joepetrowski @EgorPopelyaev
Backport 4229 Into v1.7.0 (#4288)
6927097 
Backport of #4229 into the v1.7.0 release in order to support dependent
runtimes. This version of the SDK doesn't have
`UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev pushed a commit that referenced this pull request Apr 26, 2024
@joepetrowski @EgorPopelyaev
Backport 4229 Into v1.7.0 (#4288)
962d193 
Backport of #4229 into the v1.7.0 release in order to support dependent
runtimes. This version of the SDK doesn't have
`UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev pushed a commit that referenced this pull request Apr 26, 2024
@joepetrowski @EgorPopelyaev
Backport 4229 Into v1.7.0 (#4288)
69425eb 
Backport of #4229 into the v1.7.0 release in order to support dependent
runtimes. This version of the SDK doesn't have
`UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev added a commit that referenced this pull request Apr 26, 2024
@EgorPopelyaev
Backport 4229 Into v1.6.0 (#4288)
dff3dc3 
Backport of #4229 into the v1.7.0 release in order to support dependent
runtimes. This version of the SDK doesn't have
`UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev pushed a commit that referenced this pull request Apr 26, 2024
@joepetrowski @EgorPopelyaev
Backport 4229 Into v1.7.0 (#4288)
f0a11a8 
Backport of #4229 into the v1.7.0 release in order to support dependent
runtimes. This version of the SDK doesn't have
`UncheckedOnRuntimeUpgrade`, so I do it the "old way".
EgorPopelyaev pushed a commit that referenced this pull request Apr 26, 2024
@joepetrowski @EgorPopelyaev
Backport 4229 Into v1.7.0 (#4288)
d0c26d8 
Backport of #4229 into the v1.7.0 release in order to support dependent
runtimes. This version of the SDK doesn't have
`UncheckedOnRuntimeUpgrade`, so I do it the "old way".
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/paritytech-update-for-april/7646/1

This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
@wischli
Copy link

wischli commented Jun 6, 2024

Can someone please explain to me why this fix is only part of SDK V1.11.0 and not any previous version? The error was introduced in v1.7.0 and should be backported to that version!

On Centrifuge Chain, the v1 migration leads to collator candidates being removed from the session whitelist (i.e. queued keyes is reduced to the invulnerables). It wasn't a smooth debugging process as part of our effort to upgrade to v1.7.2 because the v2 migration is simply not part of the codebase until SDK v1.11.0.

@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/paritytech-update-for-april-2024/7646/5

@wischli wischli mentioned this pull request Jun 6, 2024
Merged
4 tasks
bkchr pushed a commit that referenced this pull request Jun 6, 2024
@joepetrowski @bkchr
Backport 4229 Into v1.7.0 (#4288)
851c824 
Backport of #4229 into the v1.7.0 release in order to support dependent
runtimes. This version of the SDK doesn't have
`UncheckedOnRuntimeUpgrade`, so I do it the "old way".
bkchr pushed a commit that referenced this pull request Jun 6, 2024
@joepetrowski @bkchr
Backport 4229 Into v1.7.0 (#4288)
c00ca35 
Backport of #4229 into the v1.7.0 release in order to support dependent
runtimes. This version of the SDK doesn't have
`UncheckedOnRuntimeUpgrade`, so I do it the "old way".
@joepetrowski
Copy link
Contributor Author

joepetrowski commented Jun 6, 2024 •
edited
Loading

Can someone please explain to me why this fix is only part of SDK V1.11.0 and not any previous version? The error was introduced in v1.7.0 and should be backported to that version!

On Centrifuge Chain, the v1 migration leads to collator candidates being removed from the session whitelist (i.e. queued keyes is reduced to the invulnerables). It wasn't a smooth debugging process as part of our effort to upgrade to v1.7.2 because the v2 migration is simply not part of the codebase until SDK v1.11.0.

It was backported to 1.7: #4288

It was in the crates 10.0.2 release, e.g. as applied here: polkadot-fellows/runtimes#289

@hbulgarini hbulgarini mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgepisaltu georgepisaltu georgepisaltu approved these changes

@ggwpez ggwpez ggwpez approved these changes

@liamaharon liamaharon Awaiting requested review from liamaharon

Assignees

@joepetrowski joepetrowski

@georgepisaltu georgepisaltu

Labels
I2-bug The node fails to follow expected behavior. T2-pallets This PR/Issue is related to a particular pallet. T14-system_parachains This PR/Issue is related to system parachains.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System chains: all kusama system chain permissionless collators were kicked out of the active collator list
5 participants
@joepetrowski @Polkadot-Forum @wischli @ggwpez @georgepisaltu