Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scale-info to 2.11.0 #3682

Closed
wants to merge 2 commits into from
Closed

Bump scale-info to 2.11.0 #3682

wants to merge 2 commits into from

Conversation

antonva
Copy link
Contributor

@antonva antonva commented Mar 13, 2024

2.11.0 Implements TypeInfo for BinaryHeap. This is needed for #3190

Versions that stuck out to me as they were not at 2.10.0 are below.
If any should stay at the version they are at, i'll revert the relevant Cargo.toml files.

2.0.0

  • substrate/frame/migrations/Cargo.toml

2.1.2

  • substrate/frame/parameters/Cargo.toml

2.5.0

  • substrate/frame/sassafras/Cargo.toml
  • polkadot/xcm/xcm-executor/Cargo.toml
  • substrate/frame/examples/frame-crate/Cargo.toml
  • substrate/frame/examples/single-block-migrations/Cargo.toml
  • substrate/frame/transaction-payment/skip-feeless-payment/Cargo.toml
  • substrate/primitives/core/Cargo.toml

2.6.0

  • docs/sdk/Cargo.toml
  • substrate/frame/Cargo.toml
  • templates/minimal/runtime/Cargo.toml

2.7.0

  • bridges/snowbridge/pallets/outbound-queue/merkle-tree/Cargo.toml

2.9.0

  • bridges/snowbridge/pallets/ethereum-client/Cargo.toml
  • bridges/snowbridge/pallets/inbound-queue/Cargo.toml
  • bridges/snowbridge/pallets/outbound-queue/Cargo.toml
  • bridges/snowbridge/pallets/system/Cargo.toml
  • bridges/snowbridge/primitives/beacon/Cargo.toml
  • bridges/snowbridge/primitives/core/Cargo.toml
  • bridges/snowbridge/primitives/ethereum/Cargo.toml
  • bridges/snowbridge/primitives/router/Cargo.toml
  • cumulus/parachains/runtimes/coretime/coretime-rococo/Cargo.toml
  • cumulus/parachains/runtimes/coretime/coretime-westend/Cargo.toml
  • cumulus/parachains/runtimes/people/people-rococo/Cargo.toml
  • cumulus/parachains/runtimes/people/people-westend/Cargo.toml

2.11.0  Implements TypeInfo for BinaryHeap (#200).
which is needed for #3190
@antonva antonva requested review from athei, acatangiu, andresilva, cheme and a team as code owners March 13, 2024 16:41
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 13, 2024 16:42
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use 2.10 at the moment, so no issue to update to 2.11, see:

polkadot-sdk/Cargo.lock

Lines 17042 to 17043 in a756baf

version = "2.10.0"
source = "registry+https://github.com/rust-lang/crates.io-index"

Cargo automatically resolves to the highest SemVer compatible version.

Btw you can do zepter transpose dependency lift-to-workspace "scale-info" --fix like here #3366 to produce smaller diffs in the future (and then taplo format --config .config/taplo.toml to make CI happy).

@antonva antonva added the R0-silent Changes should not be mentioned in any release notes label Mar 14, 2024
@antonva
Copy link
Contributor Author

antonva commented Mar 14, 2024

We only use 2.10 at the moment, so no issue to update to 2.11, see:

polkadot-sdk/Cargo.lock

Lines 17042 to 17043 in a756baf

version = "2.10.0"
source = "registry+https://github.com/rust-lang/crates.io-index"

Cargo automatically resolves to the highest SemVer compatible version.

Btw you can do zepter transpose dependency lift-to-workspace "scale-info" --fix like here #3366 to produce smaller diffs in the future (and then taplo format --config .config/taplo.toml to make CI happy).

My bad on the semver, totally escaped my mind. Will be adding zepter to my toolbelt, thanks for the pointers!

@antonva antonva enabled auto-merge March 18, 2024 13:35
@antonva antonva disabled auto-merge April 2, 2024 11:51
@antonva antonva closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants