Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referenda proposal not moving to confirming automatically #200

Open
2 tasks done
crystalin opened this issue Mar 20, 2023 · 5 comments
Open
2 tasks done

Referenda proposal not moving to confirming automatically #200

crystalin opened this issue Mar 20, 2023 · 5 comments
Assignees
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@crystalin
Copy link

crystalin commented Mar 20, 2023

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

We had a proposal that people voted for and had enough vote/support to pass at a future time.
Once that time was reached, the referendum stayed in "deciding", and I also saw the scheduler being triggered earlier (by the alarm if I understood correctly).
12h later, I decided to try to vote again (with insignificant amount) and it passed it to "confirming".

Is that expected ?
I thought the alarm system was there to trigger the change when the threshold was supposed to be reached

(Also, there might have been some conviction vote delegation removed after the last vote was done during the deciding period which might be the reason the alarm didn't do anything once executed)

Steps to reproduce

No response

@bkchr
Copy link
Member

bkchr commented Mar 23, 2023

CC @kianenigma @ggwpez

@gavofyork
Copy link
Member

Possibly fixed by paritytech/substrate#13704

@kianenigma
Copy link
Contributor

Possibly fixed by paritytech/substrate#13704

any confirmation on this?

@crystalin
Copy link
Author

@kianenigma We didn't upgrade yet (probably another 2 months before this fix reaches prod), but the issue happened again today:
image
on Moonriver (Kusama) https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fwss.moonriver.moonbeam.network#/referenda

{
  Ongoing: {
    track: 0
    origin: {
      system: Root
    }
    proposal: {
      Lookup: {
        hash_: 0x31b4bd6249363c0ace1bef13719d2f3b531c95ff883209ff96dbe78cb41eaf96
        len: 188
      }
    }
    enactment: {
      After: 100
    }
    submitted: 3,867,858
    submissionDeposit: {
      who: 0x381d106C440F92654827D2B2c637Dd5B38A362A7
      amount: 10,000,000,000,000,000,000
    }
    decisionDeposit: {
      who: 0x381d106C440F92654827D2B2c637Dd5B38A362A7
      amount: 100,000,000,000,000,000,000,000
    }
    deciding: {
      since: 3,875,058
      confirming: null
    }
    tally: {
      ayes: 92,537,936,792,079,023,742,502
      nays: 89,000,100,000,000,000,000
      support: 63,219,232,282,079,023,742,502
    }
    inQueue: false
    alarm: null
  }
}

(The referenda passed the required 0.5% support some blocks before the end, but stayed in deciding)

I'm going to vote for it now to see if it moves

@crystalin
Copy link
Author

And it moved to confirming voting with 1 token:
image

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
antonva added a commit that referenced this issue Mar 13, 2024
2.11.0  Implements TypeInfo for BinaryHeap (#200).
which is needed for #3190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Status: Backlog
Development

No branches or pull requests

6 participants