Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomination-pools: add permissionless condition to chill #3453

Merged
merged 22 commits into from
Mar 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
bdfcaf1
Add permissionless condition to chill
dastansam Feb 23, 2024
7a6bdea
Add pr doc
dastansam Feb 23, 2024
7d15d4c
Merge branch 'master' into fix/nomination-pools-chill
dastansam Feb 23, 2024
76751e0
Add same check in nomnate
dastansam Feb 23, 2024
7363ebe
Merge branch 'fix/nomination-pools-chill' of github-dastansam:dastans…
dastansam Feb 23, 2024
280e3ed
Merge branch 'master' into fix/nomination-pools-chill
dastansam Feb 26, 2024
0cffe10
Merge branch 'master' into fix/nomination-pools-chill
dastansam Feb 26, 2024
3830963
Merge branch 'master' into fix/nomination-pools-chill
dastansam Feb 27, 2024
a0bff6b
Merge branch 'master' into fix/nomination-pools-chill
Ank4n Feb 28, 2024
80f0444
Add doc comment to nominate
dastansam Feb 28, 2024
84ec112
Merge branch 'fix/nomination-pools-chill' of github-dastansam:dastans…
dastansam Feb 28, 2024
08d33ee
Update doc
dastansam Feb 28, 2024
d2b21fe
Apply suggestions
dastansam Feb 28, 2024
186f5c3
Merge branch 'master' into fix/nomination-pools-chill
dastansam Feb 29, 2024
319f884
Merge branch 'master' into fix/nomination-pools-chill
dastansam Feb 29, 2024
0d871c0
Update substrate/frame/nomination-pools/src/lib.rs
dastansam Feb 29, 2024
94b0462
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
Feb 29, 2024
927e267
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Feb 29, 2024
4a11e0f
Merge branch 'master' into fix/nomination-pools-chill
dastansam Feb 29, 2024
6a00aa3
Merge branch 'master' into fix/nomination-pools-chill
dastansam Mar 2, 2024
31df111
Merge branch 'master' into fix/nomination-pools-chill
Ank4n Mar 7, 2024
dc1ae31
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Mar 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc
  • Loading branch information
dastansam committed Feb 28, 2024
commit 08d33eeefd0cd14730a51d0ada9f6047bc346c33
3 changes: 2 additions & 1 deletion prdoc/pr_3453.prdoc
Original file line number Diff line number Diff line change
@@ -6,7 +6,8 @@ title: "[pallet-nomination-pools]: `chill` is permissionless if depositor's stak
doc:
- audience: Runtime Dev
description: |
Nomination pools currently have an issue whereby member funds cannot be unbonded if the depositor bonded amount is less than MinNominatorBond.
Nomination pools currently have an issue whereby member funds cannot be unbonded if the depositor bonded amount is less than `MinNominatorBond`.
This PR makes the `chill` function permissionless if this condition is met.
Consequently, `nominate` function also checks for `depositor` to have at least `MinNominatorBond`, and returns `MinimumBondNotMet` error if not.
crates:
- name: pallet-nomination-pools
2 changes: 1 addition & 1 deletion substrate/frame/nomination-pools/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1576,7 +1576,7 @@ pub mod pallet {
use frame_system::{ensure_signed, pallet_prelude::*};
use sp_runtime::Perbill;

/// The in-code storage version.
/// The current storage version.
dastansam marked this conversation as resolved.
Show resolved Hide resolved
const STORAGE_VERSION: StorageVersion = StorageVersion::new(8);

#[pallet::pallet]
Loading