nomination-pools: add permissionless condition to chill

[dastansam]

Currently, pool member funds cannot be unbonded if the depositor's stake is less than MinNominatorBond. This usually happens after T::MinNominatorBond is increased.

To fix this, the above mentioned condition is added as a case for permissionless dispatch of chill. After pool is chilled, pool members can unbond their funds since pool won't be nominating anymore.

Consequently, same check is added to nominate call, i.e pool can not start nominating if it's depositor does not have MinNominatorBond

cc @Ank4n @kianenigma

closes #2350

Polkadot address: 16FqwPZ8GRC5U5D4Fu7W33nA55ZXzXGWHwmbnE1eT6pxuqcT

[Ank4n]

Thanks for the PR and it is looking pretty good.

Great that you added the integration test (test-staking) as well. I would advise though to instead add a separate integration test and simulate also what happens after the pool is chilled. An open question that I have, should we put the pool in blocked state when depositor bond is below min nominator bond?
Wdyt @rossbulat?

[dastansam]

Thanks for the PR and it is looking pretty good.

Great that you added the integration test (test-staking) as well. I would advise though to instead add a separate integration test and simulate also what happens after the pool is chilled. An open question that I have, should we put the pool in blocked state when depositor bond is below min nominator bond? Wdyt @rossbulat?

I think it's not necessary to put it into blocked state, since the permissioned version of chill does not do it. And I don't see that other extrinsics have different behaviour depending on the nature (permissioned/less) of the call, or maybe I am missing it?

[dastansam]

Thanks for the PR and it is looking pretty good.

Great that you added the integration test (test-staking) as well. I would advise though to instead add a separate integration test and simulate also what happens after the pool is chilled. An open question that I have, should we put the pool in blocked state when depositor bond is below min nominator bond? Wdyt @rossbulat?

I isolated the chill lifecycle into a separate test. Upon testing the behaviour, I found out that nominate should also enforce depositor to have the MinNominatorBond. Otherwise, if any member joins after pool is chilled, and his stake makes the total stake of the bonded_account more than MinNominatorBond, root/nominator of the pool can simply resume the nomination, even if the depositor does not have MinNominatorBond.

[dastansam]

hey @Ank4n,
I resolved your comments

[Ank4n]

I think it's not necessary to put it into blocked state, since the permissioned version of chill does not do it. And I don't see that other extrinsics have different behaviour depending on the nature (permissioned/less) of the call, or maybe I am missing it?

Yeah we should not do it in the chill but just conceptually if we do not block it, another user could end up joining this pool and not receive any rewards. But this is a problem frontends can solve better. For the current issue, I believe this solution is good enough.

[Ank4n]

I isolated the chill lifecycle into a separate test. Upon testing the behaviour, I found out that nominate should also enforce depositor to have the MinNominatorBond. Otherwise, if any member joins after pool is chilled, and his stake makes the total stake of the bonded_account more than MinNominatorBond, root/nominator of the pool can simply resume the nomination, even if the depositor does not have MinNominatorBond.

If the pool has more than MinNominatorBond it could be allowed to nominate since it will be eligible for reward. As long as the member can get out if they want by chilling pool, its probably okay. But we also want to punish the pool operator if they have not matched up the MinNominatorBond so keeping it chilled is also a decent option. I am okay with either option in favour of not lingering this too long.

[Ank4n]

LGTM

[liamaharon]

Nice extra tests. Thanks

[command-bot]

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5392171 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_nomination_pools. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-e4c983ee-5f92-4691-a28e-e47462995236 to cancel this command or bot cancel to cancel all commands in this pull request.

[kianenigma]

Thank you!

/tip medium

[kianenigma]

/tip medium

[substrate-tip-bot]

@dastansam Invalid network: "DOT". Please select one of: polkadot, kusama, rococo, westend.

[command-bot]

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_nomination_pools has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5392171 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5392171/artifacts/download.

[liamaharon]

/tip medium

[substrate-tip-bot]

@liamaharon You are not allowed to request a tip. Only members of paritytech/tip-bot-approvers are allowed.

[mordamax]

/tip medium

[substrate-tip-bot]

@mordamax A referendum for a medium (80 DOT) tip was successfully submitted for @dastansam (16FqwPZ8GRC5U5D4Fu7W33nA55ZXzXGWHwmbnE1eT6pxuqcT on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/referenda

[Ank4n]

bot bench substrate-pallet --pallet=pallet_nomination_pools

[command-bot]

@Ank4n https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5460998 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_nomination_pools. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-0119392a-8502-4774-95f6-2d85e9bdeff6 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@Ank4n Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_nomination_pools has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5460998 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5460998/artifacts/download.