Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete staking miner #1480

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Delete staking miner #1480

merged 2 commits into from
Sep 11, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Sep 9, 2023

Instead of renaming #1459 we should try to delete it.
New repo should be used instead https://github.com/paritytech/staking-miner-v2. Now there will also be no name-conflict for releasing it since we can release the crate staking-miner from the new repo.

New repo should be used instead https://github.com/paritytech/staking-miner-v2

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez requested a review from niklasad1 September 9, 2023 14:26
@ggwpez ggwpez added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Sep 9, 2023
@bkchr
Copy link
Member

bkchr commented Sep 9, 2023

@ggwpez you need to delete the CI job.

@kianenigma
Copy link
Contributor

@niklasad1 this is 100% not used anywhere right?

@bkchr
Copy link
Member

bkchr commented Sep 10, 2023

@niklasad1 this is 100% not used anywhere right?

Even if that is used somewhere. People should switch to the new staking miner.

@niklasad1
Copy link
Member

niklasad1 commented Sep 10, 2023

@niklasad1 this is 100% not used anywhere right?

Last I checked staking-miner-v1 is still used but it should be trivial migrate as the CLI and everything is the same but the staking-miner-v2 repo doesn't provide binaries.

As long we have some release notes that mentions to switch to staking-miner-v2 I'm okay with it.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez requested review from a team September 11, 2023 10:47
@ggwpez ggwpez requested review from a team as code owners September 11, 2023 10:47
@paritytech-ci paritytech-ci requested a review from a team September 11, 2023 11:14
@ggwpez ggwpez enabled auto-merge (squash) September 11, 2023 13:00
@ggwpez ggwpez merged commit 4b8bd90 into master Sep 11, 2023
13 checks passed
@ggwpez ggwpez deleted the oty-delete-staking-miner branch September 11, 2023 15:54
btwiuse added a commit to btwiuse/pdk that referenced this pull request Oct 5, 2023
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
* Delete staking miner

New repo should be used instead https://github.com/paritytech/staking-miner-v2

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Remove staking-miner CI jobs

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants