Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename staging-staking-miner binary to staking-miner #1459

Closed
wants to merge 2 commits into from
Closed

Rename staging-staking-miner binary to staking-miner #1459

wants to merge 2 commits into from

Conversation

Morganamilo
Copy link
Contributor

No description provided.

@Morganamilo Morganamilo added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Sep 8, 2023
@Morganamilo Morganamilo requested a review from a team September 8, 2023 10:34
@chevdor chevdor added the R0-silent Changes should not be mentioned in any release notes label Sep 8, 2023
chevdor
chevdor approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected to find more occurrences to fix but that seems to be indeed the only relevant one.

@Morganamilo
Copy link
Contributor Author

Yeah I double checked to be sure but this seems like this. The places that do run the package seem to do via cargo run -p staging-staking-miner which is good as is.

@Morganamilo Morganamilo enabled auto-merge (squash) September 8, 2023 10:45
@Morganamilo Morganamilo requested review from coderobe and a team September 8, 2023 10:52
@ordian ordian requested a review from niklasad1 September 8, 2023 11:16
@coderobe
Copy link
Contributor

coderobe commented Sep 8, 2023

we might not need this PR if staking-miner is going away entirely

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3618914

chevdor
chevdor approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes :)

@ggwpez
Copy link
Member

ggwpez commented Sep 9, 2023

@niklasad1 can we just delete the folder? That would be better I think.

@ggwpez ggwpez mentioned this pull request Sep 9, 2023
Merged
@niklasad1
Copy link
Member

niklasad1 commented Sep 9, 2023 •
edited
Loading

@niklasad1 can we just delete the folder? That would be better I think.

Yeah, that's is better but I just want to double-check that devops and some other folks that they are fine with it as well.
FWIW I promised Basti that I would take care of it next week, thanks for doing that :)

@bkchr
Copy link
Member

bkchr commented Sep 9, 2023

Let's use #1480

@bkchr bkchr closed this Sep 9, 2023
auto-merge was automatically disabled September 9, 2023 20:11

Pull request was closed

@bkchr bkchr deleted the morganamilo/renamebin branch September 9, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@coderobe coderobe coderobe approved these changes

@gilescope gilescope gilescope approved these changes

@chevdor chevdor chevdor approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Morganamilo @coderobe @paritytech-cicd-pr @ggwpez @niklasad1 @bkchr @chevdor @gilescope