Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PRdoc check #1419

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix PRdoc check #1419

merged 1 commit into from
Sep 6, 2023

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Sep 6, 2023

This PR fixes a big in the GH workflow: it removes a hard-coded value and uses the real PR number 🤦

@chevdor chevdor added the R0-silent Changes should not be mentioned in any release notes label Sep 6, 2023
@chevdor chevdor requested review from a team September 6, 2023 10:39
@chevdor chevdor enabled auto-merge (squash) September 6, 2023 10:39
ggwpez
ggwpez approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One Q so that i understand what is happening:

There has been a CI check added that enforces changelogs for each merge request?
Could you please announce this in the forum or somewhere? Otherwise i see people not getting it 🙈

@chevdor chevdor merged commit 50de035 into master Sep 6, 2023
11 checks passed
@chevdor chevdor deleted the wk-230906-fix-prdoc-ci branch September 6, 2023 11:58
@chevdor
Copy link
Contributor Author

chevdor commented Sep 6, 2023

Yes, indeed, that could help :)

Let me bring the information together in the forum: https://forum.parity.io/t/pr-documentation-prdoc/2065
That should address all your quesions.

I keep it internal for now, I can publish to the external forum once the dust settles down and the schema is considered stable.

ordian added a commit that referenced this pull request Sep 6, 2023
@ordian
Merge branch 'master' into ao-try-fixing-zombienet-slashing
27f8a62 
* master: (24 commits)
  GHW for building and publishing docker images (#1391)
  pallet asset-conversion additional quote tests (#1371)
  Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226)
  Fix PRdoc check (#1419)
  Fix the wasm runtime substitute caching bug (#1416)
  Bump enumn from 0.1.11 to 0.1.12 (#1412)
  RFC 14: Improve locking mechanism for parachains (#1290)
  Add PRdoc check (#1408)
  fmt fixes (#1413)
  Enforce a decoding limit in MultiAssets (#1395)
  Remove dynamic dispatch using `Ext` (#1399)
  Remove redundant calls to `borrow()` (#1393)
  Get rid of polling in `WarpSync` (#1265)
  Bump actions/checkout from 3 to 4 (#1398)
  Bump thiserror from 1.0.47 to 1.0.48 (#1396)
  Move Relay-Specific Shared Code to One Place (#1193)
  rust docs: add simple analytics (#1377)
  Contracts: Update read_sandbox (#1390)
  Extract block announce validation from `ChainSync` (#1170)
  [ci] Remove runtime-benchmarks from tests (#1335)
  ...
ordian added a commit that referenced this pull request Sep 7, 2023
@ordian
Merge branch 'master' into ao-polkadot-use-pinning-api
2439017 
* master: (28 commits)
  Adds base benchmark for do_tick in broker pallet (#1235)
  zombienet: use another collator image for the slashing test (#1386)
  Prevent a fail prdoc check to block (#1433)
  Fix nothing scheduled on session boundary (#1403)
  GHW for building and publishing docker images (#1391)
  pallet asset-conversion additional quote tests (#1371)
  Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226)
  Fix PRdoc check (#1419)
  Fix the wasm runtime substitute caching bug (#1416)
  Bump enumn from 0.1.11 to 0.1.12 (#1412)
  RFC 14: Improve locking mechanism for parachains (#1290)
  Add PRdoc check (#1408)
  fmt fixes (#1413)
  Enforce a decoding limit in MultiAssets (#1395)
  Remove dynamic dispatch using `Ext` (#1399)
  Remove redundant calls to `borrow()` (#1393)
  Get rid of polling in `WarpSync` (#1265)
  Bump actions/checkout from 3 to 4 (#1398)
  Bump thiserror from 1.0.47 to 1.0.48 (#1396)
  Move Relay-Specific Shared Code to One Place (#1193)
  ...
Ank4n pushed a commit that referenced this pull request Sep 8, 2023
@chevdor @Ank4n
Fix PRdoc check (#1419)
a317ef9
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
@chevdor @Daanvdplas
Fix PRdoc check (#1419)
0267372
@kiltbot kiltbot mentioned this pull request Oct 19, 2023
Closed
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
fixed on-demand parachains relay case: if better relay header is deli…
0a3f8ac 
…vered, then we must select para header that may be proved using this relay header (#1419)
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@serban300 @bkchr
Follow-up on #1419 (#1531)
77af92b 
* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@coderobe coderobe coderobe approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chevdor @coderobe @ggwpez