[ci] Remove runtime-benchmarks from tests #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
approved these changes
Sep 1, 2023
juangirini
approved these changes
Sep 2, 2023
|
Ah cool didn't see this so created another: #1360 - snuk the extra benchmark tests into an existing job so little additional load on the CI. Also looks to me there's a few other locations we want to remove the feature from. |
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
chevdor
approved these changes
Sep 4, 2023
|
The CI pipeline was cancelled due to failure one of the required jobs. |
ggwpez
approved these changes
Sep 4, 2023
I tried to combine the benchmarks with another job but it takes too long. I moved it to a separate job and if pipeline succeeds we can merge it |
altaua
reviewed
Sep 4, 2023
altaua
approved these changes
Sep 4, 2023
gilescope
approved these changes
Sep 4, 2023
ordian
added a commit
that referenced
this pull request
Sep 6, 2023
* master: (24 commits) GHW for building and publishing docker images (#1391) pallet asset-conversion additional quote tests (#1371) Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226) Fix PRdoc check (#1419) Fix the wasm runtime substitute caching bug (#1416) Bump enumn from 0.1.11 to 0.1.12 (#1412) RFC 14: Improve locking mechanism for parachains (#1290) Add PRdoc check (#1408) fmt fixes (#1413) Enforce a decoding limit in MultiAssets (#1395) Remove dynamic dispatch using `Ext` (#1399) Remove redundant calls to `borrow()` (#1393) Get rid of polling in `WarpSync` (#1265) Bump actions/checkout from 3 to 4 (#1398) Bump thiserror from 1.0.47 to 1.0.48 (#1396) Move Relay-Specific Shared Code to One Place (#1193) rust docs: add simple analytics (#1377) Contracts: Update read_sandbox (#1390) Extract block announce validation from `ChainSync` (#1170) [ci] Remove runtime-benchmarks from tests (#1335) ...
Ank4n
pushed a commit
that referenced
this pull request
Sep 8, 2023
* [ci] Remove runtime-benchmarks from tests * Update .gitlab/pipeline/test.yml Co-authored-by: Oliver Tale-Yazdi <[email protected]> * remove ing * move benchmark tests to additional tests * rm -q option * try release profile * use testnet profile * move to a separate job * rm dup --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
* [ci] Remove runtime-benchmarks from tests * Update .gitlab/pipeline/test.yml Co-authored-by: Oliver Tale-Yazdi <[email protected]> * remove ing * move benchmark tests to additional tests * rm -q option * try release profile * use testnet profile * move to a separate job * rm dup --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc https://github.com/paritytech/ci_cd/issues/864#issuecomment-1700891142