[proc macros]: only generate unsub method if not provided

proc-macros/src/lib.rs

@@ -163,6 +163,8 @@ pub(crate) mod visitor;
 ///
 /// - `name` (mandatory): name of the RPC method. Does not have to be the same as the Rust method name.
 /// - `aliases`: list of name aliases for the RPC method as a comma separated string.
+///              The aliases are kept outside namespace, so you need add that if you want aliases in the current
+///              namespace.
 /// - `blocking`: when set method execution will always spawn on a dedicated thread. Only usable with non-`async` methods.
 /// - `param_kind`: kind of structure to use for parameter passing. Can be "array" or "map", defaults to "array".
 ///
@@ -179,9 +181,11 @@ pub(crate) mod visitor;
 /// **Arguments:**
 ///
 /// - `name` (mandatory): name of the RPC method. Does not have to be the same as the Rust method name.
-/// - `unsubscribe` (optional): name of the RPC method used to unsubscribe from the subscription. Must not be the same as `name`.
-/// - `aliases` (optional): aliases for `name`.
-/// - `unsubscribe_aliases` (optional): aliases for `unsubscribe`.
+/// - `unsubscribe` (optional): name of the RPC method to unsubscribe from the subscription. Must not be the same as `name`.
+///                             This is generated for you if the subscription name starts with `subscribe`-
+/// - `aliases` (optional): aliases for `name`. The aliases are kept outside namespace,
+///                         so you need add that if you want aliases in the current namespace.
+/// - `unsubscribe_aliases` (optional): Similar to `aliases` but for `unsubscribe`.
 /// - `item` (mandatory): type of items yielded by the subscription. Note that it must be the type, not string.
 /// - `param_kind`: kind of structure to use for parameter passing. Can be "array" or "map", defaults to "array".
 ///

proc-macros/src/rpc_macro.rs

@@ -153,7 +153,7 @@ impl RpcSubscription {
 		let unsubscribe = match parse_subscribe(unsubscribe)? {
 			Some(unsub) => unsub,
 			None => build_unsubscribe_method(&name).expect(
-				format!("Could not generate the unsubscribe method with name '{name}'.  You need to provide the name manually using the `unsubscribe` attribute in your RPC API definition", name),
+				&format!("Could not generate the unsubscribe method with name '{}'. You need to provide the name manually using the `unsubscribe` attribute in your RPC API definition", name),
 			),
 		};
 

proc-macros/tests/ui/correct/alias_doesnt_use_namespace.rs

@@ -2,7 +2,8 @@ use jsonrpsee::{core::RpcResult, proc_macros::rpc};
 
 #[rpc(client, server, namespace = "myapi")]
 pub trait Rpc {
-	/// Alias doesn't use the namespace so not duplicated.
+	/// Aliases doesn't use the namespace.
+	/// Thus, this will generate `myapi_getTemp` and `getTemp`.
 	#[method(name = "getTemp", aliases = ["getTemp"])]
 	async fn async_method(&self, param_a: u8, param_b: String) -> RpcResult<u16>;