Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proc macros]: only generate unsub method if not provided #702

Merged
merged 9 commits into from
Feb 18, 2022
Merged

[proc macros]: only generate unsub method if not provided #702

merged 9 commits into from
Feb 18, 2022

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Feb 15, 2022 •
edited
Loading

Closing #698

It will only try to generate an unsubscribe method if it starts with subscribe.
Also, if unsubscribe is part of the RPC API it will override the generated unsubscribe method name

@niklasad1 niklasad1 requested a review from a team as a code owner February 15, 2022 18:25
dvdplm
dvdplm approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor grumbles

proc-macros/src/rpc_macro.rs Outdated Show resolved Hide resolved
proc-macros/tests/ui/correct/alias_doesnt_use_namespace.rs Outdated Show resolved Hide resolved
proc-macros/tests/ui/correct/alias_doesnt_use_namespace.rs Show resolved Hide resolved
proc-macros/src/lib.rs Show resolved Hide resolved
proc-macros/src/lib.rs Show resolved Hide resolved
proc-macros/src/lib.rs Outdated Show resolved Hide resolved
dvdplm
dvdplm reviewed Feb 18, 2022
View reviewed changes
proc-macros/src/lib.rs Outdated Show resolved Hide resolved
proc-macros/src/lib.rs Outdated Show resolved Hide resolved
proc-macros/src/lib.rs Outdated Show resolved Hide resolved
proc-macros/tests/ui/correct/alias_doesnt_use_namespace.rs Outdated Show resolved Hide resolved
@dvdplm dvdplm merged commit 721117d into master Feb 18, 2022
@dvdplm dvdplm deleted the na-fix-698 branch February 18, 2022 10:32
@niklasad1 niklasad1 mentioned this pull request Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niklasad1 @dvdplm