-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve feature configuration #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
hey! I fixed the comments. ty. |
@pedromfedricci ty so much for this! Do you mind sorting out the merge conflicts? :) |
cf118e5
to
fee7a7e
Compare
oh ok! master changed since I pushed this, didn't notice. |
Cheers, will merge as soon as CI is done. |
/tip small |
Please fix the following problems before calling the tip bot again:
|
@pedromfedricci As a small thank you we wanted to give you a tip in DOTs, feel free to comment with your polkadot address as instructed by the bot. :) |
This PR intends to improve the feature selection for some common use cases. Closes: #271.
Users that would want to:
The behaviour of the current feature flags is preserved, with one exception (clarification bellow), and adds more flags to provide for those above.
The exception: reexporting
RpcModule
andSubscriptionSink
in the path jsonrpsee::types:: was removed as it is also reexported at root level jsonrpsee:: when server + macro are enabled.This is to remove the path ambiguity, it also reduces the size of the resulting rlib for servers.
I didn't find the reason for having both paths, if there is I will revert it properly.
This table maps the described use cases against current flags and PR flags:
Note: compiled for x86_64-unknown-linux-gnu in debug mode.
Ty.