fix: include error code in RpcLogger #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
niklasad1
commented
May 26, 2023
| @@ -154,12 +159,16 @@ async fn ws_server_logger() { | |||
| let res: Result<String, Error> = client.request("unknown_method", rpc_params![]).await; | |||
| assert!(res.is_err()); | |||
|
|
|||
| let res: Result<String, Error> = client.request("err", rpc_params![]).await; | |||
There was a problem hiding this comment.
Expanded the test for failed RPC calls too
|
Thank you for looking into this! |
Merged
6 tasks
jsdw
reviewed
Jun 2, 2023
niklasad1
commented
Jun 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1129
In addition it contains a bug fix that were introduced by the
IntoResponsetrait and I forgot to check the outcome from theResponsePayloadwhere the user could inject there own JSON-RPC error codes etc.Thanks to @wlmyng for spotting the bug.