Point jsonrpsee to forked version to support error metrics by error code #12106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
You need to run hakari generate |
…ver + client errors by route
wlmyng
added a commit
that referenced
this pull request
May 21, 2023
wlmyng
added a commit
that referenced
this pull request
May 21, 2023
wlmyng
added a commit
that referenced
this pull request
May 22, 2023
|
Is this a temporary walkaround? Do we plan to upstream this change? |
Yes, and yes. I've opened an issue with the repo owners paritytech/jsonrpsee#1129 It is complicated by the fact that we're two major versions behind, and I think this implementation is not as straightforward in the latest version. |
|
paritytech/jsonrpsee#1135 paritytech has a PR for this now woo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corresponding change in the forked repo: wlmyng/jsonrpsee#1
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes