You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi team, I found that when using PactVerificationSpringProvider, my pactbroker.consumerversionselectors.tags property setting in the Spring application.yml file is not working. I believe this issue is caused by the implementation of PactBrokerLoader. buildConsumerVersionSelectors:
At line 133, it should use the passed-in value resolver to call parseListExpression.
Current implementation will use the default resolver SystemPropertyResolver, which is not consistent with other parseListExpression calls in buildConsumerVersionSelectors.
The text was updated successfully, but these errors were encountered:
Hi team, I found that when using
PactVerificationSpringProvider
, mypactbroker.consumerversionselectors.tags
property setting in the Springapplication.yml
file is not working. I believe this issue is caused by the implementation ofPactBrokerLoader. buildConsumerVersionSelectors
:https://github.com/DiUS/pact-jvm/blob/ec3c777f6626cd6f8c2a09e6194e00d5cf0f9378/provider/src/main/kotlin/au/com/dius/pact/provider/junitsupport/loader/PactBrokerLoader.kt#L113-L117
At line 115, it should pass the
resolver
to theshouldFallBackToTags()
and:https://github.com/DiUS/pact-jvm/blob/ec3c777f6626cd6f8c2a09e6194e00d5cf0f9378/provider/src/main/kotlin/au/com/dius/pact/provider/junitsupport/loader/PactBrokerLoader.kt#L131-L134
At line 133, it should use the passed-in value resolver to call
parseListExpression
.Current implementation will use the default resolver
SystemPropertyResolver
, which is not consistent with otherparseListExpression
calls inbuildConsumerVersionSelectors
.The text was updated successfully, but these errors were encountered: