refactor: replace if with when #1208

pact-foundation · Sep 19, 2020 · 776e7ca · 776e7ca
1 parent d802e09
commit 776e7ca
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/provider/src/main/kotlin/au/com/dius/pact/provider/junitsupport/loader/PactBrokerLoader.kt b/provider/src/main/kotlin/au/com/dius/pact/provider/junitsupport/loader/PactBrokerLoader.kt
@@ -119,9 +119,11 @@ open class PactBrokerLoader(
       pactBrokerConsumerVersionSelectors.flatMap {
         val tags = parseListExpression(it.tag, resolver)
         val parsedLatest = parseListExpression(it.latest, resolver)
-        val latest = if (parsedLatest.isEmpty()) List(tags.size) { true.toString() }
-          else if (parsedLatest.size == 1) parsedLatest.padTo(tags.size, parsedLatest[0])
-          else parsedLatest
+        val latest = when {
+          parsedLatest.isEmpty() -> List(tags.size) { true.toString() }
+          parsedLatest.size == 1 -> parsedLatest.padTo(tags.size, parsedLatest[0])
+          else -> parsedLatest
+        }
         if (tags.size != latest.size) {
           throw IllegalArgumentException("Invalid Consumer version selectors. Each version selector must have a tag " +
                   "and latest property")