Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message when accessing space via publik link that is disabled #11725

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Oct 4, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from kulmann October 4, 2024 11:13
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puhhhh... can you try implementing a unit test for this? Shows an error message when in invalid state xyz should really have a unit test any time in any scenario 🙈

@AlexAndBear
Copy link
Contributor Author

@kulmann sure, I see what can be done.

And/or should I add an e2e test for the disabled space scenario ?

@kulmann
Copy link
Member

kulmann commented Oct 5, 2024

@kulmann sure, I see what can be done.

And/or should I add an e2e test for the disabled space scenario ?

Not an e2e-test, because that's not a happy path. It would probably be much easier than writing meaningful unit tests... that's what my Puhhhh... was about 😅

@AlexAndBear AlexAndBear requested a review from kulmann October 5, 2024 12:59
Copy link

sonarcloud bot commented Oct 5, 2024

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going the extra mile with the unit test 🥇

@kulmann kulmann merged commit e4da1e3 into master Oct 7, 2024
3 checks passed
@kulmann kulmann deleted the issues/11721 branch October 7, 2024 04:01
@micbar micbar mentioned this pull request Oct 21, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to access to a disabled shared space shows no feedback
2 participants