-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error message when accessing space via publik link that is disabled #11725
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puhhhh... can you try implementing a unit test for this? Shows an error message when in invalid state xyz
should really have a unit test any time in any scenario 🙈
@kulmann sure, I see what can be done. And/or should I add an e2e test for the disabled space scenario ? |
Not an e2e-test, because that's not a happy path. It would probably be much easier than writing meaningful unit tests... that's what my |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for going the extra mile with the unit test 🥇
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: