Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to access to a disabled shared space shows no feedback #11721

Closed
jvillafanez opened this issue Oct 4, 2024 · 0 comments · Fixed by #11725
Closed

Trying to access to a disabled shared space shows no feedback #11721

jvillafanez opened this issue Oct 4, 2024 · 0 comments · Fixed by #11725
Assignees
Labels
Type:Bug Something isn't working

Comments

@jvillafanez
Copy link
Member

Describe the bug

When an anonymous user tries to access to a disabled shared space via link, the user is stuck in the password page.

There are a couple of things going on:

  • The user is asked for a password, as if it's possible to access the disabled space.
  • When the user enters the correct password, nothing happens. The user doesn't enter the space, but there isn't any error showing.

Steps to reproduce

  1. Create a new space
  2. Share the space via link (include password protection). Copy / keep the link and the password.
  3. Disable the space
  4. Logout
  5. Access anonymously to the space via the shared link
  6. Enter the password when asked

Expected behavior

An error is shown, something like "the target space is currently disabled", or just a generic "an error occurred" if we don't want to give details.

It might be better if we don't ask for the password knowing that the user won't be able to access, although it might be more complex.

Actual behavior

Nothing happens. The user can't enter the space, and there is no feedback that indicates an error.

Setup

Please describe how you started the server and provide a list of relevant environment variables or configuration files.

OCIS_XXX=somevalue
OCIS_YYY=somevalue
PROXY_XXX=somevalue

Additional context

There is a request with a 404 in the network tab, and some errors in the browser's console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants