allow querying federated sharing roles #9765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
force-pushed
the
federated-user-roles
branch
from
786060f to
e8c6715
Compare
JammingBen
reviewed
Aug 8, 2024
butonic
force-pushed
the
federated-user-roles
branch
from
e8c6715 to
bb5a199
Compare
15 tasks
butonic
force-pushed
the
federated-user-roles
branch
3 times, most recently
from
775db8f to
8d10125
Compare
|
To make requesting only actions more speciffic, we can add a query parameter: |
butonic
force-pushed
the
federated-user-roles
branch
from
8d10125 to
f98f7bd
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
federated-user-roles
branch
from
f98f7bd to
966b4e1
Compare
7 tasks
kobergj
requested changes
Aug 13, 2024
| @@ -283,7 +283,7 @@ func createShareRequestToFederatedUser(user libregraph.User, resourceId *storage | |||
| Id: &storageprovider.Grantee_UserId{UserId: &userpb.UserId{ | |||
| Type: userpb.UserType_USER_TYPE_FEDERATED, | |||
| OpaqueId: user.GetId(), | |||
| Idp: providerInfo.Domain, // the domain is persisted in the grant as u:{opaqueid}:{domain} | |||
| Idp: *user.GetIdentities()[0].Issuer, // the domain is persisted in the grant as u:{opaqueid}:{domain} | |||
There was a problem hiding this comment.
Is it guaranteed that
A) len(user.GetIdentities()) > 0
B) user.GetIdentities()[0] != nil
? Otherwise we need checks for this because it would panic.
There was a problem hiding this comment.
yes there is a check above the only line making a call to this function:
if len(user.Identities) < 1 {
return libregraph.Permission{}, errorcode.New(errorcode.InvalidRequest, "user has no federated identity")
}
// [...]
createShareRequest := createShareRequestToFederatedUser(user, statResponse.GetInfo().GetId(), providerInfoResp.ProviderInfo, cs3ResourcePermissions)
Co-authored-by: kobergj <[email protected]>
butonic
force-pushed
the
federated-user-roles
branch
2 times, most recently
from
0c766c3 to
921e99e
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
federated-user-roles
branch
from
921e99e to
99c6b66
Compare
|
kobergj
approved these changes
Aug 13, 2024
ownclouders
pushed a commit
that referenced
this pull request
Aug 13, 2024
allow querying federated sharing roles
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing permissions clients can now fetch the list of available federated sharing roles by sending a
GET /graph/v1beta1/drives/{driveid}/items/{itemid}/[email protected]/rolePermissions/any(p:contains(p/condition, '@Subject.UserType=="Federated"'))request. Note that this is the only supported filter expression. Federated sharing roles will be omitted from requests without this filter.The
/roleManagement/permissions/roleDefinitionsalso returns the new roles. Filtering them is done in a subsequent PR which requires #9727server part of #9745