Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: external collaborator search filter #11351

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Aug 12, 2024

Description

Adds a filter inside the collaborator share search input to enable searching for external users.

The available share roles are different for external users, hence there is a clear separation needed between internal and external sharing.

This filter is only available when the OCM app is enabled.

image

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Aug 12, 2024
Copy link

update-docs bot commented Aug 12, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Jannik Stehle added 3 commits August 15, 2024 10:50
Adds a filter inside the collaborator share search input to enable searching for external users.

The available share roles are different for external users, hence there is a clear separation needed between internal and external sharing.

This filter is only available when the OCM app is enabled.
@JammingBen JammingBen force-pushed the feat/external-role-filter branch from e663689 to dc6f910 Compare August 15, 2024 08:50
Copy link

sonarcloud bot commented Aug 15, 2024

@JammingBen JammingBen marked this pull request as ready for review August 15, 2024 09:35
@JammingBen JammingBen requested a review from butonic August 15, 2024 09:35
Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, works nice! will look into returning a @libre.graph.userType to the invite response

@JammingBen JammingBen merged commit 4c3dc5e into master Aug 15, 2024
3 checks passed
@kulmann kulmann deleted the feat/external-role-filter branch September 5, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants