Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only] KQL api search tests #7248

Merged
merged 1 commit into from
Sep 8, 2023
Merged

[test-only] KQL api search tests #7248

merged 1 commit into from
Sep 8, 2023

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Sep 7, 2023 •
edited
Loading

KQL feature:

  • search by file name. using different pattern
  • search by tag. using different pattern
  • search by content. using different pattern

Another

  • ApiSpaceSearch feature uses old new spaces Path
  • moved test search files inside the folder from tagSearch.feature to ApiSpaceSearch
  • removed unused code

@2403905 I commented out failed tests

@update-docs
Copy link

update-docs bot commented Sep 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor requested a review from saw-jan September 8, 2023 07:00
@fschade fschade mentioned this pull request Sep 8, 2023
Merged
9 tasks
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScharfViktor ScharfViktor merged commit 3ec2502 into master Sep 8, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the kql-search-tests branch September 8, 2023 11:18
ownclouders pushed a commit that referenced this pull request Sep 8, 2023
@ScharfViktor @fschade
kql search tests (#7248)
c3f135c 
Co-authored-by: Florian Schade <[email protected]>
@fschade fschade mentioned this pull request Sep 11, 2023
Merged
9 tasks
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScharfViktor @saw-jan @fschade