Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Pinned dependencies: create findings from processing errors #3711

Merged
merged 5 commits into from
Dec 6, 2023
Merged

🌱 Pinned dependencies: create findings from processing errors #3711

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f42478
:seedling: refactor pinned dependencies
AdamKorcz Nov 11, 2023
7f9123f
remove remediation from test
AdamKorcz Nov 22, 2023
905a98c
:seedling: create findings from processing errors
AdamKorcz Dec 1, 2023
cb14312
correct style of loop
AdamKorcz Dec 1, 2023
1abaf88
Merge branch 'main' into pinned-dependencies-2
spencerschrock Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 25 additions & 16 deletions checks/evaluation/pinned_dependencies.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,21 @@ func probeRemToRuleRem(rem *probe.Remediation) *rule.Remediation {
}
}

func dependenciesToFindings(deps []checker.Dependency) ([]finding.Finding, error) {
func dependenciesToFindings(r *checker.PinningDependenciesData) ([]finding.Finding, error) {
findings := make([]finding.Finding, 0)
for i := range deps {
rr := deps[i]

for i := range r.ProcessingErrors {
e := r.ProcessingErrors[i]
f := finding.Finding{
Message: generateTextIncompleteResults(e),
Location: &e.Location,
Outcome: finding.OutcomeNotAvailable,
}
findings = append(findings, f)
}

for i := range r.Dependencies {
rr := r.Dependencies[i]
if rr.Location == nil {
if rr.Msg == nil {
e := sce.WithMessage(sce.ErrScorecardInternal, "empty File field")
Expand Down Expand Up @@ -199,24 +210,15 @@ func PinningDependencies(name string, c *checker.CheckRequest,
pr := make(map[checker.DependencyUseType]pinnedResult)
dl := c.Dlogger

for _, e := range r.ProcessingErrors {
e := e
dl.Info(&checker.LogMessage{
Finding: &finding.Finding{
Message: generateTextIncompleteResults(e),
Location: &e.Location,
},
})
}

findings, err := dependenciesToFindings(r.Dependencies)
findings, err := dependenciesToFindings(r)
if err != nil {
return checker.CreateRuntimeErrorResult(name, err)
}

for i := range findings {
f := findings[i]
if f.Outcome == finding.OutcomeNotApplicable {
switch f.Outcome {
case finding.OutcomeNotApplicable:
if f.Location != nil {
dl.Debug(&checker.LogMessage{
Path: f.Location.Path,
Expand All @@ -232,7 +234,7 @@ func PinningDependencies(name string, c *checker.CheckRequest,
})
}
continue
} else if f.Outcome == finding.OutcomeNegative {
case finding.OutcomeNegative:
lm := &checker.LogMessage{
Path: f.Location.Path,
Type: f.Location.Type,
Expand All @@ -246,6 +248,13 @@ func PinningDependencies(name string, c *checker.CheckRequest,
lm.Remediation = probeRemToRuleRem(f.Remediation)
}
dl.Warn(lm)
case finding.OutcomeNotAvailable:
dl.Info(&checker.LogMessage{
Finding: &f,
})
continue
default:
// ignore
}
updatePinningResults(intToDepType[f.Values["dependencyType"]],
f.Outcome, f.Location.Snippet,
Expand Down
Loading