Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Pinned dependencies: create findings from processing errors #3711

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

AdamKorcz
Copy link
Contributor

What kind of change does this PR introduce?

Refactoring
(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

Currently processing errors are not converted to findings before evaluation logs them.

What is the new behavior (if this is a feature change)?**

Change the pinned dependencies evaluation so that processing errors are converted to findings with OutcomeNotAvailable before evaluation logs them.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE


@AdamKorcz AdamKorcz requested a review from a team as a code owner December 1, 2023 17:14
@AdamKorcz AdamKorcz requested review from spencerschrock and raghavkaul and removed request for a team December 1, 2023 17:14
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #3711 (1abaf88) into main (320ce05) will decrease coverage by 7.55%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3711      +/-   ##
==========================================
- Coverage   76.34%   68.79%   -7.55%     
==========================================
  Files         213      213              
  Lines       14549    14557       +8     
==========================================
- Hits        11107    10015    -1092     
- Misses       2783     3958    +1175     
+ Partials      659      584      -75     

Copy link
Contributor

@raghavkaul raghavkaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@spencerschrock
Copy link
Member

/scdiff generate Pinned-Dependencies

Copy link

github-actions bot commented Dec 5, 2023

@spencerschrock spencerschrock enabled auto-merge (squash) December 6, 2023 00:03
@spencerschrock spencerschrock merged commit 6ea9c8d into ossf:main Dec 6, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants