-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Pinned dependencies: create findings from processing errors #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
requested review from
spencerschrock and
raghavkaul
and removed request for
a team
December 1, 2023 17:14
AdamKorcz
temporarily deployed
to
integration-test
December 1, 2023 17:15 — with
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3711 +/- ##
==========================================
- Coverage 76.34% 68.79% -7.55%
==========================================
Files 213 213
Lines 14549 14557 +8
==========================================
- Hits 11107 10015 -1092
- Misses 2783 3958 +1175
+ Partials 659 584 -75 |
AdamKorcz
temporarily deployed
to
integration-test
December 1, 2023 22:01 — with
GitHub Actions
Inactive
AdamKorcz
force-pushed
the
pinned-dependencies-2
branch
from
December 4, 2023 18:06
0f83d97
to
aa8b3cc
Compare
AdamKorcz
temporarily deployed
to
integration-test
December 4, 2023 18:07 — with
GitHub Actions
Inactive
raghavkaul
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
AdamKorcz
force-pushed
the
pinned-dependencies-2
branch
from
December 5, 2023 13:29
aa8b3cc
to
cb14312
Compare
AdamKorcz
temporarily deployed
to
integration-test
December 5, 2023 13:29 — with
GitHub Actions
Inactive
/scdiff generate Pinned-Dependencies |
spencerschrock
temporarily deployed
to
integration-test
December 6, 2023 00:00 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
Currently processing errors are not converted to findings before evaluation logs them.
What is the new behavior (if this is a feature change)?**
Change the pinned dependencies evaluation so that processing errors are converted to findings with
OutcomeNotAvailable
before evaluation logs them.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
NONE