Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get initial test for showing that reward distribution works #970

Closed
wants to merge 5 commits into from

Conversation

ValarDragon
Copy link
Member

Description

Going to work on exact number calculations in a second PR, but wanted to get this up just to get the infra up for others.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #970 (97587eb) into main (957cc20) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   20.65%   20.61%   -0.04%     
==========================================
  Files         193      193              
  Lines       25141    25217      +76     
==========================================
+ Hits         5192     5198       +6     
- Misses      18997    19067      +70     
  Partials      952      952              
Impacted Files Coverage Δ
x/superfluid/keeper/epoch.go 68.51% <100.00%> (+6.98%) ⬆️
x/superfluid/client/cli/tx.go 0.00% <0.00%> (ø)
x/superfluid/keeper/hooks.go 72.22% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 957cc20...97587eb. Read the comment docs.

@mattverse
Copy link
Member

@ValarDragon what's the status of this PR? Are you planning to continue? I can also take over!

@ValarDragon
Copy link
Member Author

I think this is going to be significantly easier to rewrite with #1008

@mattverse
Copy link
Member

agreed, lets try pushing forward #1008 and then revisit this

@ValarDragon
Copy link
Member Author

yeah, no need to even get this PR merged, at most look at it for inspiration imo

@mattverse
Copy link
Member

Closing this PR in favor of #1070

@mattverse mattverse closed this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants