Test improvisation for Superfluid #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
+ Coverage 20.64% 20.96% +0.31%
==========================================
Files 193 194 +1
Lines 25270 25391 +121
==========================================
+ Hits 5218 5322 +104
- Misses 19096 19106 +10
- Partials 956 963 +7
Continue to review full report at Codecov.
|
This was referenced Mar 10, 2022
x/superfluid/keeper/stake_test.go
Outdated
| @@ -86,7 +86,7 @@ func (suite *KeeperTestSuite) SetupSuperfluidDelegate(delAddr sdk.AccAddress, va | |||
| coins := sdk.Coins{sdk.NewInt64Coin(denom, amount)} | |||
| lastLockID := suite.App.LockupKeeper.GetLastLockID(suite.Ctx) | |||
|
|
|||
| lockID := suite.LockTokens(delAddr, coins, unbondingDuration) | |||
| lockID := suite.lockupTestHelper.LockTokens(delAddr, coins, unbondingDuration) | |||
There was a problem hiding this comment.
LockTokens should be used on all LockTokens related tests, not only superfluid?
There was a problem hiding this comment.
Do you mean I should change other tests in other packages to use this as well?
ValarDragon
reviewed
Mar 10, 2022
ValarDragon
reviewed
Mar 10, 2022
ValarDragon
reviewed
Mar 14, 2022
ValarDragon
reviewed
Mar 14, 2022
ValarDragon
reviewed
Mar 14, 2022
ValarDragon
approved these changes
Mar 14, 2022
|
Changes made, planning to merge this as soon as lint and tests passes |
mergify bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
* add utility for SetupGammPoolsAndSuperfluidAssets * remove hardcoded gamm pool denoms * fix for main branch ctx => Ctx, app => App in tests * Test Changes * Add testing packages * Delete fmt * Fix lint * Remove multiple pacakges for apptesting * Add parameter for reward allocation * Improvements on test Co-authored-by: antstalepresh <[email protected]> (cherry picked from commit 00b4b2c) # Conflicts: # x/superfluid/keeper/hooks_test.go # x/superfluid/keeper/keeper_test.go
mattverse
added a commit
that referenced
this pull request
Mar 14, 2022
* Test improvisation for Superfluid (#1070) * add utility for SetupGammPoolsAndSuperfluidAssets * remove hardcoded gamm pool denoms * fix for main branch ctx => Ctx, app => App in tests * Test Changes * Add testing packages * Delete fmt * Fix lint * Remove multiple pacakges for apptesting * Add parameter for reward allocation * Improvements on test Co-authored-by: antstalepresh <[email protected]> (cherry picked from commit 00b4b2c) # Conflicts: # x/superfluid/keeper/hooks_test.go # x/superfluid/keeper/keeper_test.go * Fix merge conflictS Co-authored-by: Matt, Park <[email protected]> Co-authored-by: mattverse <[email protected]>
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improvises superfluid testing environment in the following ways:
gauge.protoFor contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer