Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous small fixes to superfluid logic #865

Merged
merged 11 commits into from
Feb 15, 2022

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Feb 14, 2022

Description

Minor core re-structure, solves launch blocking components of #830 and #864

Documents, re-structures, and re-orders the logic at EpochEnd


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #865 (16627c8) into main (513eae7) will increase coverage by 0.03%.
The diff coverage is 70.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
+ Coverage   19.86%   19.89%   +0.03%     
==========================================
  Files         190      191       +1     
  Lines       24763    24777      +14     
==========================================
+ Hits         4918     4929      +11     
- Misses      18982    18984       +2     
- Partials      863      864       +1     
Impacted Files Coverage Δ
x/superfluid/keeper/slash.go 66.66% <0.00%> (ø)
x/superfluid/keeper/superfluid_asset_store.go 80.00% <ø> (ø)
x/superfluid/keeper/hooks.go 56.25% <45.83%> (+0.15%) ⬆️
x/superfluid/keeper/gov.go 100.00% <100.00%> (ø)
x/superfluid/keeper/superfluid_asset.go 100.00% <100.00%> (ø)
x/superfluid/keeper/twap_price.go 82.97% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 513eae7...16627c8. Read the comment docs.

Copy link
Member

@UnityChaos UnityChaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/superfluid/keeper/gov.go Show resolved Hide resolved
x/superfluid/keeper/hooks.go Show resolved Hide resolved
x/superfluid/keeper/hooks.go Outdated Show resolved Hide resolved
@ValarDragon ValarDragon merged commit 9b977f3 into main Feb 15, 2022
@ValarDragon ValarDragon deleted the dev/superfluid_misc_fixes branch February 15, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants