Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Superfluid: Treat severe Gamm faults in a unified way with asset removal #864

Closed
ValarDragon opened this issue Feb 14, 2022 · 1 comment
Closed

Superfluid: Treat severe Gamm faults in a unified way with asset removal #864

ValarDragon opened this issue Feb 14, 2022 · 1 comment
Labels
C:x/superfluid

Comments

@ValarDragon
Copy link
Member

Severe faults include:

  • Pool can't be found
  • No osmo PoolAsset in pool
  • Governance removes a pool asset.

In this situation, all synthetic lockups of this denom should start unbonding, and the superfluid asset should get deleted gracefully.

Implementing the fix for all synthetic lockups is not v7 blocking, but making these all share a common method is. (Perhaps call it BeginDeleteSuperfluidAsset?
@ValarDragon ValarDragon changed the title Superfluid: Treat severe Gamm faults in a unified way with Superfluid: Treat severe Gamm faults in a unified way with asset removal Feb 14, 2022
@ValarDragon ValarDragon mentioned this issue Feb 14, 2022
Merged
4 tasks
@daniel-farina daniel-farina moved this to 🔍 Needs Review in Osmosis Chain Development Mar 2, 2022
@ValarDragon
Copy link
Member Author

This was done pre-v7

Repository owner moved this from 🔍 Needs Review to ✅ Done in Osmosis Chain Development Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/superfluid
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ValarDragon @AlpinYukseloglu