Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create CI for bumping sdk version via GA #8162

Merged
merged 14 commits into from
Apr 29, 2024
Merged

Conversation

mattverse
Copy link
Member

@mattverse mattverse commented Apr 29, 2024

Closes: #XXX

What is the purpose of the change

Bumping sdk version has always been a painful process, this PR adds a github action that bumps all the sdk versions in all the different go.mods in our repo

Testing and Verifying

A successful run on this CI can be seen in https://github.com/mattverse/osmosis/actions/runs/8872042264, mattverse#20.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

Summary by CodeRabbit

  • New Features
    • Introduced a GitHub Actions workflow to automate the updating of the Cosmos SDK version across Go mod files, enhancing efficiency and accuracy in dependency management.

@mattverse mattverse added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels Apr 29, 2024
@mattverse mattverse requested a review from a team as a code owner April 29, 2024 01:44
@github-actions github-actions bot added the T:CI label Apr 29, 2024
Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

The introduced GitHub Actions workflow, "Update Cosmos SDK Version," automates the Cosmos SDK version updates across multiple Go mod files in a repository. Triggered manually, it allows for specifying the SDK version and target branch, updates the specified files, and crafts a pull request with detailed configurations including title, assignees, and labels.

Changes

File Path Change Summary
.github/workflows/.../update-sdk-version.yml Adds a workflow to automate Cosmos SDK version updates in Go mod files, creates PR with detailed config

🐇🌟
In the meadow of code, under the sky so blue,
A little rabbit hopped, with a version new.
Through fields of Go mods, with a swift, joyous tweak,
A pull request blooms, fresh updates it seeks.
Hop, hop, hop, on GitHub it springs, 🌼
Celebrating the code, as the cosmos sings!


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a716488 and c60c0fc.
Files selected for processing (1)
  • .github/workflows/update-sdk-version.yml (1 hunks)
Additional comments not posted (3)
.github/workflows/update-sdk-version.yml (3)

3-12: The workflow trigger configuration is well-defined, allowing manual dispatch with required inputs for the SDK version and the branch. The default branch is set to 'main', which is a sensible default.


14-25: The job is configured to run on the latest Ubuntu runner and sets up Go with version 1.20. This setup is appropriate for the tasks that involve Go modules.


43-57: The configuration for creating a pull request is comprehensive, including automated title, commit message, and PR body. It also smartly handles branch creation, deletion, assignees, and labels.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment on lines +26 to +41
- name: Update SDK Version in Go Mod Files
run: |
VERSION="${{ github.event.inputs.version }}"
echo "Using version: $VERSION"
MODFILES="./go.mod ./osmoutils/go.mod ./osmomath/go.mod ./x/epochs/go.mod ./x/ibc-hooks/go.mod"
for modfile in $MODFILES; do
if [ -e "$modfile" ]; then
sed -i "s|github.com/osmosis-labs/cosmos-sdk v[0-9a-zA-Z.\-]*|github.com/osmosis-labs/cosmos-sdk $VERSION|g" $modfile
cd `dirname $modfile`
go mod tidy
cd - > /dev/null
else
echo "File $modfile does not exist"
fi
done
shell: bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Issue: Direct use of github context data in the run: script can lead to code injection vulnerabilities. Use an intermediate environment variable to mitigate this risk.

      - name: Update SDK Version in Go Mod Files
        run: |
+         VERSION=$VERSION
          echo "Using version: $VERSION"
          MODFILES="./go.mod ./osmoutils/go.mod ./osmomath/go.mod ./x/epochs/go.mod ./x/ibc-hooks/go.mod"
          for modfile in $MODFILES; do
            if [ -e "$modfile" ]; then
              sed -i "s|github.com/osmosis-labs/cosmos-sdk v[0-9a-zA-Z.\-]*|github.com/osmosis-labs/cosmos-sdk $VERSION|g" $modfile
              cd `dirname $modfile`
              go mod tidy
              cd - > /dev/null
            else
              echo "File $modfile does not exist"
            fi
          done
        shell: bash

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- name: Update SDK Version in Go Mod Files
run: |
VERSION="${{ github.event.inputs.version }}"
echo "Using version: $VERSION"
MODFILES="./go.mod ./osmoutils/go.mod ./osmomath/go.mod ./x/epochs/go.mod ./x/ibc-hooks/go.mod"
for modfile in $MODFILES; do
if [ -e "$modfile" ]; then
sed -i "s|github.com/osmosis-labs/cosmos-sdk v[0-9a-zA-Z.\-]*|github.com/osmosis-labs/cosmos-sdk $VERSION|g" $modfile
cd `dirname $modfile`
go mod tidy
cd - > /dev/null
else
echo "File $modfile does not exist"
fi
done
shell: bash
- name: Update SDK Version in Go Mod Files
run: |
VERSION=$VERSION
echo "Using version: $VERSION"
MODFILES="./go.mod ./osmoutils/go.mod ./osmomath/go.mod ./x/epochs/go.mod ./x/ibc-hooks/go.mod"
for modfile in $MODFILES; do
if [ -e "$modfile" ]; then
sed -i "s|github.com/osmosis-labs/cosmos-sdk v[0-9a-zA-Z.\-]*|github.com/osmosis-labs/cosmos-sdk $VERSION|g" $modfile
cd `dirname $modfile`
go mod tidy
cd - > /dev/null
else
echo "File $modfile does not exist"
fi
done
shell: bash

@ValarDragon ValarDragon merged commit 144e5e1 into main Apr 29, 2024
1 check passed
@ValarDragon ValarDragon deleted the mattverse/ci-sdk branch April 29, 2024 05:26
czarcas7ic added a commit that referenced this pull request May 2, 2024
* chore: add v25.x backport tag to mergify github action (#8151)

* Try out making a read cache for poolmanager pool modules (#8128)

* Try out making a read cache

* Make this stored in the keeper to fix tests

* Fix test reset caches

* Auto: update go.mod after push to dev/test_out_read_cahce that modified dependencies locally

* Add changelog

---------

Co-authored-by: github-actions <[email protected]>

* chore(deps): bump github.com/hashicorp/go-getter from 1.7.1 to 1.7.4 (#8155)

Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.1 to 1.7.4.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](hashicorp/go-getter@v1.7.1...v1.7.4)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump github.com/hashicorp/go-getter in /osmoutils (#8156)

Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.1 to 1.7.4.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](hashicorp/go-getter@v1.7.1...v1.7.4)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump github.com/hashicorp/go-getter in /x/ibc-hooks (#8154)

Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.1 to 1.7.4.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](hashicorp/go-getter@v1.7.1...v1.7.4)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* .5s epoch speedup (#8159)

* Speedup protorev by having route calculation phase not unmarshal pools (#8157)

* Another expected ~1% state machine speedup

* Add changelog

* minor other improvement

* Reduce addr decoding overhead

* chore: Create CI for bumping sdk version via GA (#8162)

* Create CI for updating sdk version

* Fix some comments

* On PR

* Use osmo v0.47.5 as default

* Fix

* Fix 2

* Fix 4

* Fix

* Final

* Final fix

* Fix PR ver

* Final

* Final

* Final

* fix: return err if type not in manager (#8170)

* chore(deps): bump actions/checkout from 3 to 4 (#8173)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump actions/setup-go from 3 to 5 (#8174)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v3...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* auto: update Go import paths to v25 on branch main (#8172)

* auto: update Go import paths to v25

* Generated protofile changes

* chore: update sqsdomain to v25

* chore: update osmoutils to latest version

---------

Co-authored-by: PaddyMc <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: PaddyMc <[email protected]>

* chore: don't use hardcoded "uosmo" string (#8145)

* check denoms for gauge creation

* changelog

* extract logic

* use uosmo var

* initial push of test fixes

* fix lint

* tidy

* tidy

* add comments

* add test cases

* chore: update cometbft and cosmos-sdk deps (#8179)

* chore: update cometbft and cosmos-sdk deps

* chore: update comments for cosmos-sdk

* auto: update asset lists (#8180)

Co-authored-by: czarcas7ic <[email protected]>

* Properly create the module account for auction (#8178)

* properly create the module account for auction

* typo

* lint

* preserve name

* updated osmoutils

* chore: consensus param change (#8177)

* consensus param change

* changelog

* err

* Update upgrades.go

---------

Co-authored-by: PaddyMc <[email protected]>

* fix: e2e and remove toolchain (#8191)

* remove toolchain

* remove exclude increment

* script

* remove build tags

* build script

* remove build arg

* fix: e2e and remove toolchain (#8191)

* remove toolchain

* remove exclude increment

* script

* remove build tags

* build script

* remove build arg

(cherry picked from commit 27548cc)

# Conflicts:
#	osmoutils/go.sum
#	x/ibc-hooks/go.sum

* fix conflict

* tidy

* Revert "tidy"

This reverts commit fabe8ea.

* Revert "fix conflict"

This reverts commit 32031fd.

* Revert "Merge branch 'main' into mergify/bp/v25.x/pr-8191"

This reverts commit 708dbdf, reversing
changes made to 29a0917.

* tidy

* run script

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: PaddyMc <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt, Park <[email protected]>
Co-authored-by: Osmosis <[email protected]>
Co-authored-by: PaddyMc <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: czarcas7ic <[email protected]>
Co-authored-by: Nicolas Lara <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:no-changelog T:CI V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants