Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update all migrated whitewhale contracts to code id 641 (backport #7966) #7971

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 5, 2024

What is the purpose of the change

Since whitewhale have migrated their contracts twice, we need to upgrade all code ids for whitewhale contracts to code id 641

Testing and Verifying

test using an in-place-testnet

what it looked like before

osmosisd q poolmanager pool 1584 --node https://rpc.osmosis.zone:443
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "572"
  contract_address: osmo1w2sdnptx8jt4vuugcauv6tj3c2syjay5rx2mxalngn7m2cywllsq6xt64k
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xbmtqY2s3Nzc0c2Vtc2xxazZmOG4wNThtNGd3Y3c1c3BxdHphMGhyamY4ZTJrc2huNHg2c3ZqcmMwbSJ9
  pool_id: "1584"

osmosisd q poolmanager pool 1575 --node https://rpc.osmosis.zone:443
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "572"
  contract_address: osmo1hnlw8ajwhgg7rsyke2t34uknp4jjcmm23zeygsu7n8cwjqnt2jsqju3nz4
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xM2M1azJ3eHEzY3g1eGFucW5xamR5cnd2Z3cwcXM4ZWE3azhjOWR6ZGRkbHRoZzU1c3VocXB2am5xNyJ9
  pool_id: "1575"

osmosisd q poolmanager pool 1514 --node https://rpc.osmosis.zone:443
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "572"
  contract_address: osmo1g883rt8ytjlhawxey39m3w90nyaxg2vfmlfh6jvnv9ec3py2hgxq9qdz53
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xNjkydGx1d3p6bW54NTZ0bTV2N3Iwbjh2NWZnMzJucmQ5bnV1a3A5ano0NThhcDd3bWNsczljejIwbSJ9
  pool_id: "1514"

osmosisd q poolmanager pool 1463 --node https://rpc.osmosis.zone:443
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "503"
  contract_address: osmo184utpa0q2x5d79ctpewwvskea50x7tr3fkgj7ge2r0uavhqexququsj3xq
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xOHIzNWx1eXlmcXA3anRlcjZqYzkzdnpoZnQ1empndnNndDJ0Z3g3NnFlejJscGpwemZ4cXd4NHluayJ9
  pool_id: "1463"

osmosisd q poolmanager pool 1462 --node https://rpc.osmosis.zone:443
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "503"
  contract_address: osmo1suf8z9ypyv3kk4egr7plde00dfetw7rcm4m9ecut7x3720z8l46q23663a
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xdzhlMnd5emhyZzN5NWdoZTl5ZzB4bjB1NzU0OGU2Mjd6czd4YWhmdm41bDYzcnkyeDh6c3RhcmF4cyJ9
  pool_id: "1462"

osmosisd q poolmanager pool 1461 --node https://rpc.osmosis.zone:443
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "503"
  contract_address: osmo14zdnsp658g6tf7s5863ygeuj9ce5g00szud3tup6sqpwhuxmdwusc2eq7v
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xNjkydGx1d3p6bW54NTZ0bTV2N3Iwbjh2NWZnMzJucmQ5bnV1a3A5ano0NThhcDd3bWNsczljejIwbSJ9
  pool_id: "1461"

what it looks like after

osmosisd q poolmanager pool 1461                                    
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "641"
  contract_address: osmo14zdnsp658g6tf7s5863ygeuj9ce5g00szud3tup6sqpwhuxmdwusc2eq7v
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xNjkydGx1d3p6bW54NTZ0bTV2N3Iwbjh2NWZnMzJucmQ5bnV1a3A5ano0NThhcDd3bWNsczljejIwbSJ9
  pool_id: "1461"

osmosisd q poolmanager pool 1462                                    
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "641"
  contract_address: osmo1suf8z9ypyv3kk4egr7plde00dfetw7rcm4m9ecut7x3720z8l46q23663a
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xdzhlMnd5emhyZzN5NWdoZTl5ZzB4bjB1NzU0OGU2Mjd6czd4YWhmdm41bDYzcnkyeDh6c3RhcmF4cyJ9
  pool_id: "1462"

osmosisd q poolmanager pool 1514                                    
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "641"
  contract_address: osmo1g883rt8ytjlhawxey39m3w90nyaxg2vfmlfh6jvnv9ec3py2hgxq9qdz53
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xNjkydGx1d3p6bW54NTZ0bTV2N3Iwbjh2NWZnMzJucmQ5bnV1a3A5ano0NThhcDd3bWNsczljejIwbSJ9
  pool_id: "1514"

osmosisd q poolmanager pool 1575                                    
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "641"
  contract_address: osmo1hnlw8ajwhgg7rsyke2t34uknp4jjcmm23zeygsu7n8cwjqnt2jsqju3nz4
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xM2M1azJ3eHEzY3g1eGFucW5xamR5cnd2Z3cwcXM4ZWE3azhjOWR6ZGRkbHRoZzU1c3VocXB2am5xNyJ9
  pool_id: "1575"

osmosisd q poolmanager pool 1584                                    
pool:
  '@type': /osmosis.cosmwasmpool.v1beta1.CosmWasmPool
  code_id: "641"
  contract_address: osmo1w2sdnptx8jt4vuugcauv6tj3c2syjay5rx2mxalngn7m2cywllsq6xt64k
  instantiate_msg: eyJ3aGl0ZV93aGFsZV9wb29sIjogIm9zbW8xbmtqY2s3Nzc0c2Vtc2xxazZmOG4wNThtNGd3Y3c1c3BxdHphMGhyamY4ZTJrc2huNHg2c3ZqcmMwbSJ9
  pool_id: "1584"

Or unit test by:

  • cd app/upgrades/v24
  • go test ./... -cover

Summary by CodeRabbit

  • New Features
    • Enhanced the upgrade handler to support a wider range of pool IDs and introduced a new code ID comparison logic for migrations.
  • Tests
    • Updated tests to reflect the new code ID values for specific pools.

This is an automatic backport of pull request #7966 done by [Mergify](https://mergify.com).

* fix: update all migrated whitewhale contracts to code id 641

* chore: update CHANGELOG.md

(cherry picked from commit 505cc98)
@mergify mergify bot assigned PaddyMc Apr 5, 2024
@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Apr 5, 2024
@czarcas7ic czarcas7ic merged commit 22544fd into v24.x Apr 5, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the mergify/bp/v24.x/pr-7966 branch April 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants