-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update all migrated whitewhale contracts to code id 641 #7966
Conversation
WalkthroughThe recent update introduces enhancements to the upgrade handling mechanism within the application. Specifically, it expands the pool IDs array to encompass more values in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -84,6 +84,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
* [#7951](https://github.com/osmosis-labs/osmosis/pull/7951) Only migrate selected cl incentives | |||
* [#7938](https://github.com/osmosis-labs/osmosis/pull/7938) Add missing swap events for missing swap event for cw pools. | |||
* [#7957](https://github.com/osmosis-labs/osmosis/pull/7957) Update to the latest version of ibc-go | |||
* [#7966](https://github.com/osmosis-labs/osmosis/pull/7966) Update all governance migrated white whale pools to code id 641 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the changelog entry accurately reflects the changes made in pull request #7966, including the migration of all governance migrated white whale pools to code ID 641.
* fix: update all migrated whitewhale contracts to code id 641 * chore: update CHANGELOG.md (cherry picked from commit 505cc98)
…7971) * fix: update all migrated whitewhale contracts to code id 641 * chore: update CHANGELOG.md (cherry picked from commit 505cc98) Co-authored-by: PaddyMc <[email protected]>
What is the purpose of the change
Since whitewhale have migrated their contracts twice, we need to upgrade all code ids for whitewhale contracts to code id 641
Testing and Verifying
test using an
in-place-testnet
what it looked like before
what it looks like after
Or unit test by:
cd app/upgrades/v24
go test ./... -cover
Summary by CodeRabbit