Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Sqrt calls in TickToSqrtPrice #7599

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

ValarDragon
Copy link
Member

Reduce the number of sqrt invocations in TickToSqrtPrice. Depending on the way the error goes, we save either 1 or 2 Sqrt calls (before there were always 4).

This is basic from being a binary search. We should do some analysis in the future, to remove the need from computing either boundary sqrt. I think we should be able to get away without having either, and thus just need 1 or 2 comparisons to get which partition we need to be in. (Versus our now 3-4)

@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:no-changelog A:backport/v22.x backport patches to v22.x branch A:backport/v23.x backport patches to v23.x branch labels Feb 23, 2024
@ValarDragon ValarDragon reopened this Feb 26, 2024
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry it took some time to review, took some time to understand what's going on! 😃

x/concentrated-liquidity/math/tick.go Outdated Show resolved Hide resolved
@ValarDragon
Copy link
Member Author

I appreciate the review!

@ValarDragon ValarDragon closed this Mar 6, 2024
@ValarDragon ValarDragon reopened this Mar 6, 2024
@ValarDragon ValarDragon merged commit 5a763c1 into main Mar 6, 2024
1 check passed
@ValarDragon ValarDragon deleted the dev/reduce_tick_to_sqrtprice_calls branch March 6, 2024 02:50
mergify bot pushed a commit that referenced this pull request Mar 6, 2024
* Reduce Sqrt calls in TickToSqrtPrice

* Move error to types

(cherry picked from commit 5a763c1)
mergify bot pushed a commit that referenced this pull request Mar 6, 2024
* Reduce Sqrt calls in TickToSqrtPrice

* Move error to types

(cherry picked from commit 5a763c1)
mergify bot pushed a commit that referenced this pull request Mar 6, 2024
* Reduce Sqrt calls in TickToSqrtPrice

* Move error to types

(cherry picked from commit 5a763c1)
ValarDragon added a commit that referenced this pull request Mar 6, 2024
* Reduce Sqrt calls in TickToSqrtPrice

* Move error to types

(cherry picked from commit 5a763c1)

Co-authored-by: Dev Ojha <[email protected]>
ValarDragon added a commit that referenced this pull request Mar 6, 2024
* Reduce Sqrt calls in TickToSqrtPrice

* Move error to types

(cherry picked from commit 5a763c1)

Co-authored-by: Dev Ojha <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v22.x backport patches to v22.x branch A:backport/v23.x backport patches to v23.x branch A:no-changelog C:x/concentrated-liquidity V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants