You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TickToSqrtPrice is currently taking .5% of sync speed at 4 sqrt calls. After #7599 , we will be doing either 2 or 3 sqrt calls. However, we are doing one sqrt of these sqrt calls in all cases to check "boundary" cases. We should be able to remove the boundary sqrt calls, by just making more precise claims on the error bands of sqrtPrice.Square() and tick, err := CalculatePriceToTick(price).
Acceptance Criteria
Prove to ourselves its safe to remove these based on error tolerances
Remove these calls.
We should re-assess this as sync speed improves for other reasons (e.g. I/O improvements, parallelism, or fixing cosmwasm / IBC overheads), as then this will become more worthwhile.
The text was updated successfully, but these errors were encountered:
Background
TickToSqrtPrice is currently taking .5% of sync speed at 4 sqrt calls. After #7599 , we will be doing either 2 or 3 sqrt calls. However, we are doing one sqrt of these sqrt calls in all cases to check "boundary" cases. We should be able to remove the boundary sqrt calls, by just making more precise claims on the error bands of sqrtPrice.Square() and
tick, err := CalculatePriceToTick(price)
.Acceptance Criteria
We should re-assess this as sync speed improves for other reasons (e.g. I/O improvements, parallelism, or fixing cosmwasm / IBC overheads), as then this will become more worthwhile.
The text was updated successfully, but these errors were encountered: