-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(protorev): send rewards to dev acc once per epoch #7564
Conversation
^ this PR should be merged before this one, so it can be properly wired |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't see a test showing that multi-denom distributes are working
Will get test in and then merge, thanks all |
Im actually seeing the multi-denom test here already osmosis/x/protorev/keeper/hooks_test.go Lines 864 to 873 in 2978b5e
@ValarDragon lmk if that suffices. |
Ah great, thanks! I missed that then |
Closes: #7518
What is the purpose of the change
The protorev module currently calculates profits and sends the dev reward cut after every backrun. This adds unnecessary read/write overhead, causing measurable detriment to sync speed.
This PR tracks the difference between the last epoch's protorev module account to the balance at the current epoch, calculates the dev rewards once, and does a single send.