feat: Burning ProtoRev Profit #7509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
commented
Feb 16, 2024
ValarDragon
approved these changes
Feb 17, 2024
|
Can you add a changelog, and then I think it's good to merge? I think we need to make this function get called periodically pre release though. I'll try to make an issue for that today |
|
Will add the change log! I'll also update this to migrate non-osmo denom profits to the community pool. |
ValarDragon
reviewed
Feb 20, 2024
| expectedErr: false, | ||
| expectedDevProfit: sdk.NewCoin(types.OsmosisDenomination, osmomath.NewInt(20)), | ||
| expectedDevProfit: sdk.NewCoin(types.OsmosisDenomination, osmomath.NewInt(200)), |
There was a problem hiding this comment.
ah numbers 10x'd because below we changed distribute profit call to be hard coded at 1000, just switching which denom,
ValarDragon
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7320
What is the purpose of the change
This PR updates the profit distribution mechanism of protorev such that if the profit is denominated in uosmo, send the profit to the zero address (
osmo1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqmcn030) after redistributing the developer profits.Testing and Verifying
Added test coverage to the updated distribution logic.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)