feat(math): add mutative api for BigDec.BigInt() #6867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattverse
requested changes
Nov 15, 2023
Co-authored-by: Matt, Park <[email protected]>
|
Please ping me once r4r |
|
I am sorry |
pysel
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Thanks for the PR! I think it would be better to make a table-driven unit test for this one and use the functionality for asserting mut/non-mut results we already have for tests. Example: https://github.com/osmosis-labs/osmosis/blob/main/osmomath/decimal_test.go#L1585
|
Thanks you |
|
I'm waiting for a PR cosmos/cosmos-sdk#18576 at cosmos hub. Give me more time |
|
check it out in PR #6993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PR17803 I think we should also have such an API